-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow extensions to announce contentType to AppWrapper, make saving images possible #11607
base: master
Are you sure you want to change the base?
Allow extensions to announce contentType to AppWrapper, make saving images possible #11607
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this? Can't the extension just use resource.mimeType directly?
I would like to keep the api surface minimal
Ah, it's the other way round - the extension needs to tell the mimetype to oC Web because we are only creating a new file? |
No, it's updating an existing file |
Open for suggestions regarding the approach. We could check the |
242e39c
to
37be09a
Compare
@dschmidt do you have a better suggestion with regards to API design? Or @JammingBen maybe? |
Hmmm, I can't really think of a non-ugly solution here. You could give apps the possibility to define a custom save task and call that if given. Though it would be a lot of code duplication in this specific case... so I guess I'm fine with this approach. Maybe add a comment to the |
Description
Necessary for owncloud/web-extensions#43