-
Notifications
You must be signed in to change notification settings - Fork 6
[tests-only] add e2e test for app json viewer #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be0b031
to
750f445
Compare
750f445
to
4563a67
Compare
7 tasks
4563a67
to
2bb14c2
Compare
db4931e
to
3c72ed5
Compare
nirajacharya2
approved these changes
Mar 10, 2025
amrita-shrestha
requested changes
Mar 10, 2025
Signed-off-by: nabim777 <[email protected]>
3c72ed5
to
962a1ac
Compare
amrita-shrestha
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@nabim777 can we merge this or is there anything still to be done? |
Yes we can merge it @LukasHirt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR, an e2e test is added for the
web-app-json-viewer
extension.steps added:
jsonFile.json
Test run command
For more details on how to run the test, please refer to the link here.
Related Issue
Screenshots (if appropriate):
Following video shows what's automated in the E2E test for
web-app-json-viewer
extension (added in this PR)Screencast.from.02-18-2025.12.41.28.PM.webm
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: