Skip to content

[tests-only] add e2e test for app json viewer #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

nabim777
Copy link
Member

@nabim777 nabim777 commented Feb 18, 2025

Description

In this PR, an e2e test is added for the web-app-json-viewer extension.

steps added:

  • upload json file jsonFile.json
  • view json file

Test run command

pnpm test:e2e --project='json-viewer-chromium'

For more details on how to run the test, please refer to the link here.

Related Issue

Screenshots (if appropriate):

Following video shows what's automated in the E2E test for web-app-json-viewer extension (added in this PR)

Screencast.from.02-18-2025.12.41.28.PM.webm

How Has This Been Tested?

  • test environment:
  • CI
  • locally
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nabim777 nabim777 force-pushed the tests/app-json-viewer branch 3 times, most recently from be0b031 to 750f445 Compare February 18, 2025 08:39
@nabim777 nabim777 self-assigned this Feb 18, 2025
@nabim777 nabim777 marked this pull request as ready for review February 18, 2025 08:45
@nabim777 nabim777 force-pushed the tests/app-json-viewer branch from 750f445 to 4563a67 Compare February 18, 2025 09:45
@nabim777 nabim777 force-pushed the tests/app-json-viewer branch 2 times, most recently from db4931e to 3c72ed5 Compare March 5, 2025 07:48
@nabim777 nabim777 requested a review from nirajacharya2 March 5, 2025 08:30
@nabim777 nabim777 force-pushed the tests/app-json-viewer branch from 3c72ed5 to 962a1ac Compare March 10, 2025 10:45
Copy link

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@LukasHirt
Copy link
Collaborator

@nabim777 can we merge this or is there anything still to be done?

@nabim777
Copy link
Member Author

@nabim777 can we merge this or is there anything still to be done?

Yes we can merge it @LukasHirt

@nabim777 nabim777 merged commit 456ae21 into main Mar 11, 2025
2 checks passed
@nabim777 nabim777 deleted the tests/app-json-viewer branch March 11, 2025 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants