fix(collaboration): [OCISDEV-484] remove leading dot from file extension #11814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the leading dot from the file extension during registration. This fixes a bug where the `COLLABORATION_WOPI_DISABLED_EXTENSIONS` config was ignored. Technically, admins could set the env var with leading dots as well. However, documentation always specifies this without leading dots.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This removes the leading dot from the file extension during registration. This fixes a bug where the
COLLABORATION_WOPI_DISABLED_EXTENSIONSconfig was ignored. Technically, admins could set the env var with leading dots as well. However, documentation always specifies this without leading dots.Motivation and Context
Extensions are correctly checked.
How Has This Been Tested?
Types of changes