Debug log message when no bearer header found in request #141
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
============================================
+ Coverage 82.12% 82.15% +0.02%
Complexity 199 199
============================================
Files 21 21
Lines 705 706 +1
============================================
+ Hits 579 580 +1
Misses 126 126
Continue to review full report at Codecov.
|
| @@ -43,6 +43,7 @@ public function auth(IRequest $request) { | |||
| $authHeader = $request->getHeader('Authorization'); | |||
|
|
|||
| if (strpos($authHeader, 'Bearer ') === false) { | |||
| \OC::$server->getLogger()->debug('No Authorization: Bearer header detected', ['app' => 'oauth2']); | |||
There was a problem hiding this comment.
this will fire on each and every request with basic auth and/or session cookie (and/or public requests)
but debug mode is okay I guess ..... you might want to add if a cookie (and which) or basic auth headers are in place to support debugging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To aid debugging when apache/$webserver/$proxy strips the auth headers.