-
Notifications
You must be signed in to change notification settings - Fork 398
🔧 drop php < 8.2 and add laravel 12 #1006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Morten D. Hansen <[email protected]> Co-authored-by: erikn69 <[email protected]>
Merged
Yes, we can update the code, I don't see a problem |
@erikn69 sorry if we overlapped, I think I'm all done with this now so whatever you need to do is cool 🙏 |
I was just going over something else and spotted that the registerAuditingServiceProvider function in the install command isn't relevant for new laravel 11+ installs because the app config file doesn't list service providers any more https://github.com/laravel/laravel/blob/11.x/config/app.php Should probably just remove the function? |
I did a quick review and everything is in order, I don't have any suggestions
has been unnecessary for a long time, It is safe to remove it great work 🎉 |
@erikn69 any chance this can be released since the Larave 12 is released :) |
I think there are two pending to release v14 |
There is definitely some interesting parts left in the v14 branch but I wouldn't have called them blockers on the release. I've got a note in my reminders to update the documentation for the event dispatch change. |
As discussed in a few other places and referencing the v14-dev branch
phpunit 11 is flagging deprecations for all the
@test
,@dataProvider
, etc because phpunit 12 drops them in favour of attributes but as I see #1003 renames every test function I didn't want to conflict by addingtest_
to each one.Presumably we could also do promoted constructor properties on the event classes?
Replaces #1004