Skip to content

🔧 drop php < 8.2 and add laravel 12 #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 17, 2025
Merged

🔧 drop php < 8.2 and add laravel 12 #1006

merged 8 commits into from
Feb 17, 2025

Conversation

willpower232
Copy link
Contributor

As discussed in a few other places and referencing the v14-dev branch

  • remove mentions of lumen
  • upgrade old style factories
  • drop everything before laravel 11 and php 8.2
  • turns out this also means phpunit 11 is the minimum version so I let phpunit update the config file which may or may not have been a bad idea
  • v13-dev hasn't existed for a while so the mention in composer.json seems broken so I removed
  • v14-dev also changed the workflow to run on all branches so I got that too, not sure how useful that is and of course they haven't released laravel 12 yet so it won't pass
  • the apt update in the workflow dates back to php 7.4 so I removed too
  • my editor alphabetised the dependencies in composer.json, I think that is an option somewhere but didn't go looking for it

phpunit 11 is flagging deprecations for all the @test, @dataProvider, etc because phpunit 12 drops them in favour of attributes but as I see #1003 renames every test function I didn't want to conflict by adding test_ to each one.

Presumably we could also do promoted constructor properties on the event classes?

Replaces #1004

Co-authored-by: Morten D. Hansen <[email protected]>
Co-authored-by: erikn69 <[email protected]>
@willpower232 willpower232 self-assigned this Feb 15, 2025
@erikn69
Copy link
Contributor

erikn69 commented Feb 17, 2025

phpunit 11 is flagging deprecations for all the @test, @dataProvider, etc because phpunit 12 drops them in favour of attributes but as I see #1003 renames every test function I didn't want to conflict by adding test_ to each one.

Merged

Presumably we could also do promoted constructor properties on the event classes?

Yes, we can update the code, I don't see a problem

@willpower232
Copy link
Contributor Author

@erikn69 sorry if we overlapped, I think I'm all done with this now so whatever you need to do is cool 🙏

@willpower232
Copy link
Contributor Author

I was just going over something else and spotted that the registerAuditingServiceProvider function in the install command isn't relevant for new laravel 11+ installs because the app config file doesn't list service providers any more

https://github.com/laravel/laravel/blob/11.x/config/app.php

Should probably just remove the function?

@erikn69
Copy link
Contributor

erikn69 commented Feb 17, 2025

I did a quick review and everything is in order, I don't have any suggestions

Should probably just remove the function?

has been unnecessary for a long time, It is safe to remove it

great work 🎉

@parallels999
Copy link
Contributor

parallels999 commented Feb 17, 2025

What about f49ab23, c264fd6

@erikn69 erikn69 merged commit 717d307 into master Feb 17, 2025
7 checks passed
@aglipanci
Copy link
Contributor

@erikn69 any chance this can be released since the Larave 12 is released :)

@parallels999
Copy link
Contributor

@willpower232
Copy link
Contributor Author

There is definitely some interesting parts left in the v14 branch but I wouldn't have called them blockers on the release.

I've got a note in my reminders to update the documentation for the event dispatch change.

@parallels999
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants