Test: target REQUEST_COOKIES_NAMES - 060 #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebitosh
changed the title
Sebitosh
changed the title
Sebitosh
force-pushed
the
test-target-cookiename
branch
from
0e6a011 to
a502b52
Compare
|
Please resolve the conflicts. May be you could wait until PR #29 will be merged. |
Signed-off-by: Sebitosh <[email protected]>
Sebitosh
force-pushed
the
test-target-cookiename
branch
from
a502b52 to
b3ffee1
Compare
|
Rebased & regenerated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#27
Same idea as for #29 , but for target REQUEST_COOKIES_NAMES.
Also does tests with multiple cookies inside the collection to confirm the behavior does not change if multiple and unrelated cookies are present (and we should decide if this approach is relevant).
Assessment on V2
All tests pass on V2
Assessment on V3 (using the not yet merged #24 infra)
All tests pass on V3