Fixes waiting for level-driven informers to stop #4383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcaamano
reviewed
May 23, 2024
trozet
force-pushed
the
fix_informer_race
branch
2 times, most recently
from
4c1bc4c
to
3a68983
Compare
We were not waiting on for informers to fully shutdown for level-driven controllers. As a consequence, goroutines would still be running handling events while the next unit test case ran. In this case, a handler with no workqueue (like node_tracker) would attempt to read global config, while the next test case was modifying the global config, leading to a data race. Fixes: ovn-org#4381 Signed-off-by: Tim Rozet <[email protected]>
jcaamano
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not waiting on for informers to fully shutdown for level-driven controllers. As a consequence, goroutines would still be running handling events while the next unit test case ran. In this case, a handler with no workqueue (like node_tracker) would attempt to read global config, while the next test case was modifying the global config, leading to a data race.
Fixes: #4381
Thanks to @npinaeva for helping me debug this one!