kubevirt: Propertly remove migration leftovers #4370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinqon
force-pushed
the
kubevirt-propertly-remove-left-overs
branch
2 times, most recently
from
71d5668
to
5993aa9
Compare
qinqon
force-pushed
the
kubevirt-propertly-remove-left-overs
branch
2 times, most recently
from
1ae2e96
to
16efdab
Compare
pperiyasamy
reviewed
May 22, 2024
| pod, err := fakeOvn.fakeClient.KubeClient.CoreV1().Pods(t.namespace).Get(context.TODO(), t.podName, metav1.GetOptions{}) | ||
| Expect(err).NotTo(HaveOccurred()) | ||
| pod.Status.Phase = corev1.PodSucceeded | ||
| _, err = fakeOvn.fakeClient.KubeClient.CoreV1().Pods(t.namespace).UpdateStatus(context.TODO(), pod, metav1.UpdateOptions{}) |
There was a problem hiding this comment.
nit. does UpdateStatus expect to pass at first attempt itself ? or do we need multiple attempts with eventually here ?
There was a problem hiding this comment.
This is unit testing, fakeClient has no conflicts mechanism, this is good enough.
| Expect(err).NotTo(HaveOccurred()) | ||
| pod.Status.Phase = corev1.PodSucceeded | ||
| _, err = fakeOvn.fakeClient.KubeClient.CoreV1().Pods(t.namespace).UpdateStatus(context.TODO(), pod, metav1.UpdateOptions{}) | ||
| Expect(err).NotTo(HaveOccurred()) |
|
LGTM |
|
Failure not related |
|
@qinqon can you add doc text to |
qinqon
force-pushed
the
kubevirt-propertly-remove-left-overs
branch
2 times, most recently
from
9cbaca9
to
5cae8fc
Compare
|
Unit test failure not related |
After merging [1] the live migration leftovers were not removed since all the VM's pods are at completed state so the cleanup was skip. This change simplify that logic by removing left overs if all the VM's pods are completed. [1] 469c4e8 Signed-off-by: Enrique Llorente <[email protected]>
qinqon
force-pushed
the
kubevirt-propertly-remove-left-overs
branch
from
5cae8fc
to
2713fc8
Compare
jcaamano
approved these changes
May 27, 2024
tssurya
added
area/e2e-testing
feature/kubevirt-live-migration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does and why is it needed
After merging 469c4e8 the live migration leftovers were not removed since all the VM's pods are at completed state so the cleanup was skip.
This change simplify that logic by removing left overs if all the VM's pods are completed.