Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix listen ip conversion #260

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix listen ip conversion #260

merged 1 commit into from
Jan 23, 2024
+97 −34

Conversation

satoren
Copy link
Member

@satoren satoren commented Jan 18, 2024 •
edited
Loading

listen_ip was able to pass a map or string, but omitted to take it into account when converting it to listen_info

@satoren satoren requested a review from h3poteto as a code owner January 18, 2024 05:50
@satoren satoren force-pushed the fix_listen_ip_conversion branch from 76364e9 to 0ce8fc4 Compare January 18, 2024 05:50
@coveralls
Copy link

coveralls commented Jan 18, 2024 •
edited
Loading

Coverage Status

coverage: 92.517% (+0.05%) from 92.466%
when pulling 17296f8 on fix_listen_ip_conversion
into b89b868 on main.

@satoren satoren force-pushed the fix_listen_ip_conversion branch 4 times, most recently from 98e1fd0 to 91823c7 Compare January 18, 2024 06:12
@satoren satoren force-pushed the fix_listen_ip_conversion branch from 91823c7 to 17296f8 Compare January 18, 2024 06:52
@satoren satoren self-assigned this Jan 18, 2024
h3poteto
h3poteto approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@h3poteto h3poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoren satoren merged commit 69ec8df into main Jan 23, 2024
4 checks passed
@satoren satoren deleted the fix_listen_ip_conversion branch January 23, 2024 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@h3poteto h3poteto h3poteto approved these changes

Assignees

@satoren satoren

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoren @coveralls @h3poteto