Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cross compile #254

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Fix cross compile #254

merged 2 commits into from
Dec 25, 2023

Conversation

satoren
Copy link
Member

@satoren satoren commented Dec 25, 2023 •
edited
Loading

https://github.com/oviceinc/mediasoup-elixir/actions/runs/7319896562/job/19938303196

@coveralls
Copy link

coveralls commented Dec 25, 2023 •
edited
Loading

Coverage Status

coverage: 92.466%. remained the same
when pulling c434a2e on fix_cross_compile
into 8221d56 on main.

h3poteto
h3poteto approved these changes Dec 25, 2023
View reviewed changes
Copy link
Contributor

@h3poteto h3poteto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/release.yml Outdated
@@ -4,6 +4,7 @@ on:
push:
branches:
- main
- fix_cross_compile
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before you merge this PR, please remove this line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Of course.

@satoren satoren marked this pull request as ready for review December 25, 2023 07:08
@satoren satoren enabled auto-merge (squash) December 25, 2023 07:13
@satoren satoren merged commit bda9e1a into main Dec 25, 2023
4 checks passed
@satoren satoren deleted the fix_cross_compile branch December 25, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h3poteto h3poteto h3poteto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoren @coveralls @h3poteto