fix credo warnings

oviceinc · Jan 21, 2025 · 4db883b · 4db883b
1 parent b34fb3c
commit 4db883b
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -74,6 +74,8 @@ jobs:
       matrix:
         rust:
           - stable
+    env:
+      RUSTLER_PRECOMPILATION_MEDIASOUP_BUILD: "true"
     steps:
     - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
     - name: Set up Elixir
@@ -104,8 +106,6 @@ jobs:
             _build
         key: ${{ runner.os }}-rust-${{ matrix.rust }}-mix-${{ hashFiles('**/mix.lock') }}
         restore-keys: ${{ runner.os }}-rust-${{ matrix.rust }}-mix-
-    - name: Install precompiled nif
-      run: mix rustler_precompiled.download Mediasoup.Nif --only-local
     - name: Run dialyzer
       run: mix dialyzer
     - name: generate docs

diff --git a/lib/nif.ex b/lib/nif.ex
@@ -6,6 +6,7 @@ defmodule Mediasoup.Nif do
   version = Mix.Project.config()[:version]
 
   defmodule Build do
+    @moduledoc false
     def prebuild_targets() do
       # Anything that is difficult to prebuilt in cross compile is excluded for now.
       [
@@ -22,7 +23,7 @@ defmodule Mediasoup.Nif do
       ]
     end
 
-    defp is_prebuild_target?() do
+    defp prebuild_target?() do
       case RustlerPrecompiled.target() do
         {:ok, target} -> prebuild_targets() |> Enum.any?(&String.contains?(target, &1))
         _ -> false
@@ -32,7 +33,7 @@ defmodule Mediasoup.Nif do
     def force_build?(),
       do:
         System.get_env("RUSTLER_PRECOMPILATION_MEDIASOUP_BUILD") in ["1", "true"] or
-          not is_prebuild_target?()
+          not prebuild_target?()
   end
 
   use RustlerPrecompiled,

diff --git a/test/integration/test_util.ex b/test/integration/test_util.ex
@@ -1,4 +1,7 @@
 defmodule Mediasoup.TestUtil do
+  @moduledoc """
+  Test utilities
+  """
   import ExUnit.Assertions
 
   def worker_leak_setup_all(_context \\ %{}) do