Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(password): implementation component #447

Merged
merged 2 commits into from May 14, 2024
Merged

refactor(password): implementation component #447

merged 2 commits into from May 14, 2024

Conversation

aesteves60
Copy link
Contributor

No description provided.

@aesteves60 aesteves60 requested a review from a team as a code owner May 10, 2024 12:48
@dpellier dpellier added the v18 label May 10, 2024
Leotheluck

This comment was marked as resolved.

Sign in to view

@aesteves60
Copy link
Contributor Author

aesteves60 commented May 13, 2024 •
edited by Leotheluck

  • Instead of You can add your own style on the password element using the part input., we should prefer using You can add your own style on the password component using '::part(input)'
    I let the previous version for stay the consistence with the others component

dpellier
dpellier reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@dpellier dpellier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the mask button needs to be disabled on readonly?
purpose of the state is to let the input content still be readable

Leotheluck

This comment was marked as resolved.

Sign in to view

@aesteves60 aesteves60 force-pushed the refactor/ods-password branch 2 times, most recently from 65530a8 to 5a2f420 Compare May 14, 2024 09:27
@aesteves60 aesteves60 force-pushed the refactor/ods-password branch 2 times, most recently from 6c4f0f5 to 3a0b10c Compare May 14, 2024 13:02
@dpellier dpellier merged commit 85bf9ef into refactor/ods May 14, 2024
5 of 7 checks passed
@dpellier dpellier deleted the refactor/ods-password branch May 14, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpellier dpellier dpellier approved these changes

@feoche feoche feoche approved these changes

@Leotheluck Leotheluck Leotheluck approved these changes

Assignees
No one assigned
Labels
v18
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aesteves60 @dpellier @feoche @Leotheluck