Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(code): implement component #446

Merged
merged 3 commits into from May 14, 2024
Merged

feat(code): implement component #446

merged 3 commits into from May 14, 2024

Conversation

dpellier
Copy link
Contributor

As there are no specific designs for this component, I went with the simpliest version, which is the same as the actual.
Which means no toolip on copy button (unlike clipboard), could be added on another iteration if actually asked for.

@dpellier dpellier added the v18 label May 10, 2024
@dpellier dpellier requested a review from a team as a code owner May 10, 2024 08:37

<Canvas of={ CodeStories.Default } sourceState='shown' />

## With copy button enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To match with the other documentations I would maybe only put "CanCopy", or "Can Copy"

@ovh ovh deleted a comment from ovh-cds May 14, 2024
feoche

This comment was marked as resolved.

@dpellier dpellier requested a review from feoche May 14, 2024 13:59
@dpellier dpellier merged commit 4c936c8 into refactor/ods May 14, 2024
4 of 7 checks passed
@dpellier dpellier deleted the refactor/ods-code branch May 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants