Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): remove margin & padding of host #403

Merged
merged 5 commits into from May 21, 2024
Merged

Conversation

skhamvon
Copy link
Contributor

Remove margin & padding to prevent click event outside of the component

@skhamvon skhamvon marked this pull request as ready for review March 19, 2024 14:46
@skhamvon skhamvon requested a review from a team as a code owner March 19, 2024 14:46
Copy link
Contributor

@dpellier dpellier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried the React example and was able to click the disabled button on Chromium and Safari

aesteves60

This comment was marked as resolved.

Copy link
Contributor

@astagnol astagnol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, I am able to click when disabled on several browsers (react example):
Firefox (123.0.1) -> can click just a few pixels outside the disabled button (but ok on the border)
Safari (Version 17.3.1 ) -> same
Chromium (Version 112.0.5615.49) -> can click on the disabled button (button, border, a few pixels outside of it)

dpellier

This comment was marked as outdated.

@dpellier
Copy link
Contributor

dpellier commented Apr 2, 2024

There is an issue with Chromium and slot content in a disabled element (see: https://issues.chromium.org/issues/40679491#comment13)
Issue is reproductible on other framework too.
A workaround could be to "silence" the slot using something like:
Capture d’écran 2024-04-02 à 15 05 55

Please give it a try following the whole process:

  • reproduce the issue on your local Chromium
  • apply the fix
  • test on Chromium / FF / Safari (/ Edge)

@dpellier dpellier added the bug Something isn't working label Apr 3, 2024
@feoche feoche merged commit b15a409 into master May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants