Feature/charts sb #950
Merged
Feature/charts sb #950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ciaranschutte
commented
Jun 14, 2025
ciaranschutte
commented
- working storybook configs with first story for barchart written, more to come!
Co-authored-by: Anders Richardsson <[email protected]>
Co-authored-by: Anders Richardsson <[email protected]>
ciaranschutte
changed the base branch from
feature/arranger-charts
to
feature/charts_colors
Base automatically changed from
feature/charts_colors
to
feature/arranger-charts
June 16, 2025 15:55
ciaranschutte
commented
Jun 16, 2025
Comment on lines
+3
to
+9
| export const chartContainerDecorator = (Story) => ( | ||
| <div style={{ height: '300px', width: '300px', display: 'flex' }}> | ||
| <ChartContainer> | ||
| <Story /> | ||
| </ChartContainer> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
storybook story wrapper for display area
| "vite": "^6.3.5", | ||
| "vitest": "^3.2.2" | ||
| }, | ||
| "msw": { |
There was a problem hiding this comment.
curious property. what is it for?
There was a problem hiding this comment.
mock service worker, easy mocking of HTTP calls which should work nicely for gql. though I might just test with local data, smaller scope seems better
| "vitest": "^3.2.2" | ||
| } | ||
| } | ||
| "name": "@overture-stack/arranger-charts", |
There was a problem hiding this comment.
seems like the file switched to spaces? is eslint/prettier off in your system?
There was a problem hiding this comment.
I will double check! nice catch
| import type { Meta, StoryObj } from '@storybook/react-vite'; | ||
| import { action } from 'storybook/actions'; | ||
|
|
||
| import { chartContainerDecorator } from '../../../../.storybook/decorators'; |
There was a problem hiding this comment.
rofl 🤣 no way to set up a #storybook?
There was a problem hiding this comment.
I'll see what I can whip up ;p
justincorrigible
approved these changes
Jun 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.