Refactor Application.cpp

[HifiExperiments]

Closes #931

(apologies to whoever reviews this)

Application.cpp has gotten totally out of control over the years (in many cases because of my dumb decisions). This is an attempt to corral it. I've organized the code as best I could into sections - Assets, Camera, Entities, Events, Graphics, Plugins, Setup, and UI - and divided the implementations into separate, smaller files. I completely rebuilt the includes from scratch so we only have what's necessary. I broke some of the classes into their own files. Overall, I changed very little functionally. I removed a few unused variables and functions but nearly everything is directly copy-pasted.

Testing-wise, things should just work as before. In particular, anything related to startup, login UI, and plugins.

Funding

This project is funded through NGI0 Entrust, a fund established by NLnet with financial support from the European Commission's Next Generation Internet program. Learn more at the NLnet project page.

[HifiExperiments]

oh yeah @daleglass it didn't look like this was ever set to true, so I deleted it + the one place it was used, is that ok?

[daleglass]

Oops, that looks like something I screwed up.

Memory is a bit rusty right now about why I added that, but I take it PROFILE_RANGE_IF_LONGER and similar are not safe to call before some sort of initialization is done, so a _profilingInitialized=true; is supposed to go somewhere in the startup code after some profiling system init code is called.

[HifiExperiments]

it seemed to be working ok for me without it, maybe if it's a problem during testing I can add it back?

[daleglass]

Sure, it's simple enough that it'd be easy. I did quite a lot of rearranging of that code, and right now can't recall if maybe I just fixed this in some other way in the end.

[HifiExperiments]

hm

/__w/overte/overte/interface/src/scripting/PerformanceScriptingInterface.cpp:14:10: fatal error: QtQML: No such file or directory
   14 | #include <QtQML>
      |          ^~~~~~~

I'll look into that...

[ksuprynowicz]

This is really awesome :)
Application.cpp needed refactoring badly and this will make future work a lot easier.
I didn't find any problems, but I have few questions and I found what I think is earlier thread safety issue in the code.

[ksuprynowicz]

I'm also having trouble building it on Linux using Overte-builder:

[ksuprynowicz]

I tested it on Windows, and it asks to log in every time. A different than usual login screen is used for this:

Kraftwerk world becomes entirely white after skybox loads:

No audio devices are detected:

[ksuprynowicz]

It also seems that login screen that it uses in VR is intended for desktop?

[ksuprynowicz]

The good thing about that different login screen though is that it has option to continue anonymously. Ours is badly missing this.

[HifiExperiments]

I believe I've fixed the audio device issue. for the login screen, it turns out I had accidentally deleted _disableLoginScreen which was always set to true. so whatever that fullscreen login page was for, it appears to have been disabled intentionally at some point. I've re-disabled it to just avoid messing with stuff, but maybe we should look into re-enabling it properly at some point. I'm not sure if this also fixed the VR login screen, if that's still a problem could you send me a screenshot?

I wasn't able to reproduce the issue in kraftwerk; I wonder if the download got corrupted or something? does it still happen if you clear your caches, including ktx cache?

[JulianGro]

I gave this a test on Linux and so far, everything works fine. I tried clearing shader cache and ktx cache as well. In both scenarios, Kraftwerk renders properly.

[ksuprynowicz]

I tested it again and now everything works well :)

[ksuprynowicz]

Would someone like to test in VR on Windows? I don't have a VR setup at the moment. If all works well we could merge it.

[HifiExperiments]

there are some conflicts now, I’ll probably wait until after the next release to rebase and resolve them just to avoid causing any problems

[Armored-Dragon]

Would someone like to test in VR on Windows? I don't have a VR setup at the moment. If all works well we could merge it.

I did some brief testing in VR and everything seems to work as expected.

there are some conflicts now, I’ll probably wait until after the next release to rebase and resolve them just to avoid causing any problems

I will also take a look at this again after the rebase!

[HifiExperiments]

I've rebased this and it's all ready to be reviewed + tested again!

[HifiExperiments]

I've rebased this again and it's still ready for final testing + review!

[ksuprynowicz]

I just tested it on Linux and on every start no microphone is selected. Default microphone needs to be selected every start. Output seems to be selected properly.

[ksuprynowicz]

It seems that microphone issue happens only on Linux. It happens on every start and no input is selected:

[ksuprynowicz]

It looks like the microphone issue doesn't happen in Desktop mode on Windows, but does happen in VR mode on Windows, exactly like in Desktop mode on Linux.

[ksuprynowicz]

Teleport script in the tower near Overte_hub spawn point is broken, it fails with message:

[01/05 19:47:37] [CRITICAL] [overte.scriptengine] [about:Entities 1] Function call failed: "failed on line 26 column 8 with message: "Uncaught ReferenceError: Window is not defined" backtrace: ReferenceError: Window is not defined
[01/05 19:47:37] [CRITICAL] [overte.scriptengine]     at Object.enterEntity (https://aleziakurdis.github.io/inertia/teleporters/teleporter.js:26:9)
[01/05 19:47:37] [CRITICAL] [overte.scriptengine] [about:Entities 1] JS function call failed:

[ksuprynowicz]

After some more testing input selection issue seems to happen sometimes in Desktop mode on Windows too.

[HifiExperiments]

darn! thank you for testing, I'll look into those

[HifiExperiments]

there’s definitely some weirdness around audio devices on startup. the previous fix (to the much earlier issue of the audio devices not showing up) was to reorder some initialization: 2345bcc#diff-379416a9df19174e2bf0d9d644da8269931fbe2f7f0516719eedb75f8d022b34R810

so…perhaps there’s still something wrong about the order of that versus the loading from settings

[HifiExperiments]

thanks again to @ksuprynowicz, the audio issue appears to be fixed!

I haven't looked at the teleport issue yet, if that's still an issue I will take a look this weekend, but otherwise I think this is ready for more testing actually I just gave it a try and it seems to work?

[ksuprynowicz]

We did a lot of testing on the newest version of this PR, both in desktop and VR. All seems to work good :)

[HifiExperiments]

amazing! this is ready to merge then from my side. 🎉

[ksuprynowicz]

Everything looks good :)

[HifiExperiments]

HUGE thank you @ksuprynowicz for all your help with this!

[ksuprynowicz]

@HifiExperiments Thank you for the refactor - it was a massive undertaking and was really needed with how big Application.cpp got XD