Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple accounts in domain web UI #1350

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Armored-Dragon
Copy link
Member

@Armored-Dragon Armored-Dragon commented Mar 10, 2025

This adds support for multiple user accounts in the domain web UI using HTTP basic authentication.

TODO:

  • Prohibit empty usernames
  • Prohibit duplicate usernames
  • No account ("open access") support
  • Create update path for existing configs
  • UI detect when attempting to change password to easily allow updating.
    (The UI does not yet detect when the password fields have been changed, so another setting has to be toggled to give the option to save the new values)

Closes #734

@Armored-Dragon Armored-Dragon added enhancement New feature or request work in progress Do not merge yet labels Mar 10, 2025
@Armored-Dragon Armored-Dragon self-assigned this Mar 10, 2025
@Armored-Dragon Armored-Dragon added the server If used for a Pull Request, server packages are going to be built. label Mar 10, 2025
@Armored-Dragon Armored-Dragon added needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested and removed work in progress Do not merge yet labels Mar 11, 2025
@Armored-Dragon
Copy link
Member Author

Something I noticed (or failed to) in the config migration steps is that when a migration is preformed on settings, their original settings don't seem to be deleted/removed from the config file. I am assuming this is intentional and as such the existing domain-server account will continue to have the username and password hash in the config.

@Armored-Dragon Armored-Dragon marked this pull request as ready for review March 11, 2025 09:35
@JulianGro
Copy link
Member

In case you want GitHub Actions to create server packages: The way it currently works is that it creates server packages when you add the server label. If you push a commit and the server label was already added in the past that doesn't count. In that case, you need to remove the server label and add it again.

That is technically a bug, but since making server packages involves running 12 jobs, this might be a good way of saving infrastructure costs 😅.

@Armored-Dragon Armored-Dragon added server If used for a Pull Request, server packages are going to be built. and removed server If used for a Pull Request, server packages are going to be built. labels Mar 11, 2025
@Armored-Dragon
Copy link
Member Author

In case you want GitHub Actions to create server packages: The way it currently works is that it creates server packages when you add the server label. If you push a commit and the server label was already added in the past that doesn't count. In that case, you need to remove the server label and add it again.

That is technically a bug, but since making server packages involves running 12 jobs, this might be a good way of saving infrastructure costs 😅.

Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs CR This pull request needs to be code reviewed needs QA This pull request needs to be tested server If used for a Pull Request, server packages are going to be built.
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Support multiple accounts in domain web UI
2 participants