Skip to content

fix: make superset ports consistent in local and dev #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025
Merged

fix: make superset ports consistent in local and dev #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/20250326_155128_danyal.faheem_make_ports_consistent.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- [Improvement] Make superset ports consistent on local and dev by running it on 2247 in both environments. (by @Danyal-Faheem)
2 changes: 1 addition & 1 deletion tutorcairn/patches/caddyfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Cairn
{{ CAIRN_HOST }}{$default_site_port} {
reverse_proxy cairn-superset:8000
reverse_proxy cairn-superset:2247
}
2 changes: 1 addition & 1 deletion tutorcairn/patches/k8s-services
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ metadata:
spec:
type: NodePort
ports:
- port: 8000
- port: 2247
protocol: TCP
selector:
app.kubernetes.io/name: cairn-superset
Expand Down
4 changes: 2 additions & 2 deletions tutorcairn/templates/cairn/build/cairn-superset/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ USER superset
COPY --chown=superset:superset ./cairn /app/superset/cairn

# This is required to have a proper healthcheck
ENV SUPERSET_PORT=8000
ENV SUPERSET_PORT=2247

ENTRYPOINT []
CMD gunicorn \
--bind "0.0.0.0:8000" \
--bind "0.0.0.0:2247" \
--access-logfile '-' \
--error-logfile '-' \
--workers 2 \
Expand Down