fix windows-hide-console for bun SFE

[rithvikvibhu]

What does this PR do?

#15894 added an option --windows-hide-console but it isn't really called. This PR fixes it.

• Documentation or TypeScript types (it's okay to leave the rest blank in this case)
• Code changes

How did you verify your code works?

before, generated exe always shows as console even with windows-hide-console set:

$ file testbin.exe
testbin.exe: PE32+ executable for MS Windows 6.00 (console), x86-64, 13 sections

now, if the flag is set:

$ file testbin.exe
testbin.exe: PE32+ executable for MS Windows 6.00 (GUI), x86-64, 13 sections

[Jarred-Sumner]

How does this PR fix it? The changes here likely do not compile and are not related to the PR description

Happy to re-open when you've pushed up relevant changes

[cirospaciari]

Thank you for the contributions, just some comments + can you add a test?

[rithvikvibhu]

@cirospaciari replied to the comments. For the test, I think test\bundler\bundler_compile.test.ts is a good place for it. But how do you think it should test since it directly modifies the exeutable? Run file? Or do whatever file does (read the exe and ensure the bytes are changed?

[cirospaciari]

Thank you for the replies.
If file is available on every windows we can use it running with spawn, otherwise we need todo it manually

[rithvikvibhu]

fyi none of the failing tests are related to these changes afaics. Do you think updating with main or rebasing will help?