Glob support for workspace names in bun install

[zackradisic]

What does this PR do?

Implements glob support for workspace names in bun install, allowing all pattern syntax supported by the Glob API to be used in "workspaces", except for exclusions which are not implemented yet.

This also implements an optimization for glob patterns that end with a component that is a literal path (e.g. packages/**/package.json)

• Documentation or TypeScript types (it's okay to leave the rest blank in this case)
• Code changes

Fixes: #1918

How did you verify your code works?

I wrote automated tests

Zig files changed:

• I checked the lifetime of memory allocated to verify it's (1) freed and (2) only freed when it should be
• I included a test for the new code, or an existing test covers it
• JSValue used outside outside of the stack is either wrapped in a JSC.Strong or is JSValueProtect'ed
• I wrote TypeScript/JavaScript tests and they pass locally (bun-debug test test-file-name.test)

[github-actions]

❌ @zackradisic, your commit has failing tests :(

💪 2 failing tests Darwin AARCH64

• test/cli/install/bunx.test.ts SIGTERM
• test/js/bun/http/serve.test.ts 1 failing

💻 1 failing tests Darwin x64 baseline

• test/js/web/workers/worker.test.ts 1 failing

💻 3 failing tests Darwin x64

• test/cli/install/bun-install.test.ts 12 failing
• test/js/bun/test/test-test.test.ts 1 failing
• test/js/web/workers/worker.test.ts 1 failing

🐧🖥 1 failing tests Linux x64

• test/js/node/child_process/child_process-node.test.js 1 failing

🪟💻 6 failing tests Windows x64 baseline

• test/cli/install/bunx.test.ts 1 failing
• test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
• test/integration/next-pages/test/dev-server.test.ts 1 failing
• test/integration/next-pages/test/next-build.test.ts 1 failing
• test/js/bun/shell/bunshell.test.ts 1 failing
• test/js/node/dns/node-dns.test.js 2 failing

🪟💻 9 failing tests Windows x64

• test/cli/install/bunx.test.ts 1 failing
• test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
• test/integration/next-pages/test/dev-server.test.ts 1 failing
• test/integration/next-pages/test/next-build.test.ts 1 failing
• test/js/bun/shell/bunshell.test.ts 1 failing
• test/js/node/child_process/child_process.test.ts 1 failing
• test/js/node/dns/node-dns.test.js 2 failing
• test/js/node/fs/promises.test.js 1 failing
• test/js/web/fetch/fetch.tls.test.ts 1 failing

View logs

[dylan-conway]

Left a few comments. I think the tests are failing because of the test directory used in the new tests. It's looking for a folder where the tests are run, not in the temp folder.

[Jarred-Sumner]

@zackradisic more merge conflicts

[Jarred-Sumner]

@zackradisic test failures

[zackradisic]

@dylan-conway are the failing bun-install tests relevant? They don't look related to the changes in this PR

[dylan-conway]

@dylan-conway are the failing bun-install tests relevant? They don't look related to the changes in this PR

it should install in such a way that two identical packages with different peer dependencies are different instances is unrelated, it's a new regression in main, but the other yarn test... failures on windows seem suspicious. If you can't repro them locally it's already existing flakiness

[zackradisic]

@dylan-conway are the failing bun-install tests relevant? They don't look related to the changes in this PR

it should install in such a way that two identical packages with different peer dependencies are different instances is unrelated, it's a new regression in main, but the other yarn test... failures on windows seem suspicious. If you can't repro them locally it's already existing flakiness

Can't repro them locally so looks like its flakiness and this should now be mergeable

[dylan-conway]

Looks great