Add powershell completer (#8939) #10424
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShaunLawrie
commented
Apr 22, 2024
| // log("GetBinaryTypeW({}) = {d}. isExecutable={}", .{ bun.fmt.utf16(path), out, result }); | ||
|
|
||
| // return result; | ||
| const stringPath = bun.String.createFromOSPath(path); |
There was a problem hiding this comment.
It's my first time writing zig. This works but I'm sure there's a better way to do this. Windows 16bit-ish paths that couldn't be squished to utf8 would not match any executable extensions.
|
Also for duplicate issue #10293 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This adds completions for PowerShell. It should work back to PowerShell v5 and cross platform.
Rather than add hard coded completions it pulls available args from the bun help.
How did you verify your code works?
Built and installed on Windows for now, the idea needs fleshing out which is why this is a draft.
bun-debug test test-file-name.test)