fix(stream): flush enqueued entries on every pull on direct streams #10249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Direct streams only flush their enqueued entries either 1) on close or 2) when the ReadableStreamController requests a flush. Libraries such as
react-dom/server
assume entries enqueued during a ReadableStreamController.pull() are flushed at times other than when the stream is closed.To remedy this, we flush all enqueued entries in a direct stream at the end of a pull() invocation.
Fixes #7321.
Fixes #5664.
How did you verify your code works?
bun-debug test test-file-name.test
)