New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: make c source dependencies inherit build mode from cmake #10096

Open

nektro wants to merge 14 commits into main from nektro-patch-64727

Contributor

nektro commented Apr 8, 2024 •

edited

this still allows the option to build the c dependencies in release and bun in debug while setting the default to debug which greatly aids in debugging, allowing crashes and stack traces that pass through c dependencies to not be optimized out when building from source locally.


build: make c source dependencies inherit build mode from cmake

e17d259

github-actions bot commented Apr 8, 2024 •

edited

❌ @nektro 12 files with test failures on bun-windows-x86_64-haswell

test\cli\install\bunx.test.ts 1 failing
test\cli\install\registry\bun-install-registry.test.ts SIGTERM
test\integration\next-pages\test\dev-server-ssr-100.test.ts 1 failing
test\integration\next-pages\test\dev-server.test.ts 1 failing
test\integration\next-pages\test\next-build.test.ts 1 failing
test\js\bun\glob\scan.test.ts 6 failing
test\js\bun\shell\bunshell.test.ts 4 failing
test\js\bun\shell\commands\rm.test.ts 4 failing
test\js\bun\shell\leak.test.ts 2 failing
test\js\deno\performance\performance.test.ts 1 failing
test\js\node\dns\node-dns.test.js 2 failing
test\js\third_party\esbuild\esbuild-child_process.test.ts SIGTERM

View test output

^{#5b2fdd93e6962e1c585e611ef5302d3b425306cb}

nektro added 3 commits

April 8, 2024 19:30


delete unused files

f46de3c


fix macos CI

d03a214


implement this pr for windows

0913aa3

github-actions bot commented Apr 9, 2024 •

edited

❌ @nektro 8 files with test failures on bun-darwin-aarch64:

test/cli/install/migration/complex-workspace.test.ts 1 failing
test/js/bun/http/serve.test.ts 2 failing
test/js/bun/shell/leak.test.ts SIGTERM
test/js/bun/spawn/spawn-kill-signal.test.ts 2 failing
test/js/bun/spawn/spawn.test.ts SIGTERM
test/js/bun/test/test-test.test.ts 1 failing
test/js/node/http/node-http.test.ts 1 failing
test/js/node/http2/node-http2.test.js 1 failing

View test output

^{#5b2fdd93e6962e1c585e611ef5302d3b425306cb}


mimalloc on windows needs release mode

c36fe77

github-actions bot commented Apr 9, 2024 •

edited

❌ @nektro 4 files with test failures on bun-darwin-x64:

test/cli/install/registry/bun-install-registry.test.ts 3 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/bun/shell/leak.test.ts 1 failing
test/js/node/http/node-http.test.ts 1 failing

View test output

^{#5b2fdd93e6962e1c585e611ef5302d3b425306cb}

github-actions bot commented Apr 9, 2024 •

edited

❌ @nektro 5 files with test failures on linux-x64-baseline:

test/integration/mysql2/mysql2.test.ts 6 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/node/watch/fs.watchFile.test.ts 1 failing
test/js/web/timers/setInterval.test.js 1 failing

View test output

^{#5b2fdd93e6962e1c585e611ef5302d3b425306cb}

github-actions bot commented Apr 9, 2024 •

edited

❌ @nektro 4 files with test failures on linux-x64:

test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/node/http2/node-http2.test.js 1 failing
test/js/node/watch/fs.watchFile.test.ts 1 failing

View test output

^{#5b2fdd93e6962e1c585e611ef5302d3b425306cb}

nektro marked this pull request as ready for review

April 10, 2024 00:18


ci: make CMAKE_BUILD_TYPE env var global to the workflow

61ee0bd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment