Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add remaining private methods #46

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add remaining private methods #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions Source/JavaScriptCore/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1412,13 +1412,19 @@ set(JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS

jit/Width.h
runtime/ClonedArguments.h
runtime/InternalFieldTuple.h
runtime/SuppressedError.h

runtime/JSModuleEnvironment.h
runtime/JSModuleEnvironmentInlines.h
)

if(USE_BUN_JSC_ADDITIONS)
list(APPEND JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS
runtime/InternalFieldTuple.h
runtime/SuppressedError.h
runtime/SuppressedErrorConstructor.h
runtime/SuppressedErrorPrototype.h
)
endif()
if(USE_INSPECTOR_SOCKET_SERVER)
list(APPEND JavaScriptCore_PRIVATE_FRAMEWORK_HEADERS
API/JSRemoteInspectorServer.h
Expand Down
1 change: 1 addition & 0 deletions Source/JavaScriptCore/Sources.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,6 +1228,7 @@ yarr/YarrTZoneImpls.cpp
// Derived Sources
yarr/YarrCanonicalizeUnicode.cpp

// BUN_JSC_ADDITION Sources
runtime/InternalFieldTuple.cpp
runtime/SuppressedError.cpp
runtime/SuppressedErrorConstructor.cpp
Expand Down
3 changes: 2 additions & 1 deletion Source/JavaScriptCore/builtins/BuiltinNames.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ namespace JSC {


#define JSC_COMMON_PRIVATE_IDENTIFIERS_EACH_PROPERTY_NAME(macro) \
BUN_JSC_COMMON_PRIVATE_IDENTIFIERS(macro) \
JSC_COMMON_BYTECODE_INTRINSIC_FUNCTIONS_EACH_NAME(macro) \
JSC_COMMON_BYTECODE_INTRINSIC_CONSTANTS_EACH_NAME(macro) \
macro(add) \
Expand Down Expand Up @@ -210,7 +211,7 @@ namespace JSC {
macro(hasOwn) \
macro(indexOf) \
macro(pop) \
macro(asyncContext) \

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ extra newline aligns with WebKit repo source (so closer to original source material).


namespace Symbols {
#define DECLARE_BUILTIN_STATIC_SYMBOLS(name) extern JS_EXPORT_PRIVATE SymbolImpl::StaticSymbolImpl name##Symbol;
Expand Down