Set -mno-omit-leaf-frame-pointer

oven-sh · May 5, 2024 · 18eaec2 · 18eaec2
1 parent 4e85607
commit 18eaec2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 8 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -79,8 +79,8 @@ jobs:
  CXX: "${{matrix.brew_prefix}}/llvm@16/bin/clang++"
  CMAKE_C_COMPILER: "${{matrix.brew_prefix}}/llvm@16/bin/clang"
  CMAKE_CXX_COMPILER: "${{matrix.brew_prefix}}/llvm@16/bin/clang++"
- CMAKE_C_FLAGS: "-fuse-ld=lld -fno-exceptions ${{matrix.lto_flag}} -fvisibility=hidden -fvisibility-inlines-hidden -O3"
- CMAKE_CXX_FLAGS: "-fuse-ld=lld -I${{matrix.brew_prefix}}/llvm/include -fno-exceptions ${{matrix.lto_flag}} -fvisibility=hidden -fvisibility-inlines-hidden -O3"
+ CMAKE_C_FLAGS: "-fuse-ld=lld -fno-exceptions ${{matrix.lto_flag}} -fvisibility=hidden -fvisibility-inlines-hidden -O3 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer"
+ CMAKE_CXX_FLAGS: "-fuse-ld=lld -I${{matrix.brew_prefix}}/llvm/include -fno-exceptions ${{matrix.lto_flag}} -fvisibility=hidden -fvisibility-inlines-hidden -O3 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer"
  CMAKE_OSX_DEPLOYMENT_TARGET: "12.0"
  CMAKE_BUILD_TYPE: ${{matrix.CMAKE_BUILD_TYPE}}
  PACKAGE_JSON_ARCH: ${{matrix.package_json_arch}}

diff --git a/Dockerfile b/Dockerfile
@@ -43,9 +43,9 @@ RUN install_packages \
  lldb-${LLVM_VERSION} \
  pkg-config \
  ruby-dev
- 
+
 RUN for f in /usr/lib/llvm-${LLVM_VERSION}/bin/*; do ln -sf "$f" /usr/bin; done && \
-  ln -sf clang /usr/bin/cc && \
+ ln -sf clang /usr/bin/cc && \
  ln -sf clang /usr/bin/c89 && \
  ln -sf clang /usr/bin/c99 && \
  ln -sf clang++ /usr/bin/c++ && \
@@ -72,8 +72,8 @@ ENV LTO_FLAG=${LTO_FLAG}
 
 
 RUN --mount=type=tmpfs,target=/webkitbuild \
- export CFLAGS="$CFLAGS $LTO_FLAG" && \
- export CXXFLAGS="$CXXFLAGS $LTO_FLAG" && \
+ export CFLAGS="$CFLAGS -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer $LTO_FLAG" && \
+ export CXXFLAGS="$CXXFLAGS -mno-omit-leaf-frame-pointer -fno-omit-frame-pointer $LTO_FLAG" && \
  cd /webkitbuild && \
  cmake \
  -DPORT="JSCOnly" \
@@ -90,8 +90,8 @@ RUN --mount=type=tmpfs,target=/webkitbuild \
  -DCMAKE_EXE_LINKER_FLAGS="-fuse-ld=lld" \
  -DCMAKE_AR=$(which llvm-ar) \
  -DCMAKE_RANLIB=$(which llvm-ranlib) \
- -DCMAKE_C_FLAGS="$CFLAGS --no-omit-frame-pointer" \
- -DCMAKE_CXX_FLAGS="$CXXFLAGS --no-omit-frame-pointer" \
+ -DCMAKE_C_FLAGS="$CFLAGS" \
+ -DCMAKE_CXX_FLAGS="$CXXFLAGS" \
  -G Ninja \
  /webkit && \
  cd /webkitbuild && \