Issue #59 - Inflation Adjustment #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knaaptime
requested changes
Nov 4, 2019
There was a problem hiding this comment.
thanks for getting this started @JennEYoon
a few things before we can get this merged
knaaptime
reviewed
Nov 4, 2019
| @@ -675,6 +675,31 @@ def store_ncdb(filepath): | |||
|
|
|||
| df = df.set_index("geoid") | |||
|
|
|||
| #### Beginning of New Code #### | |||
There was a problem hiding this comment.
can you remove these comments?
knaaptime
requested changes
Nov 4, 2019
Comment on lines
+680
to
+701
| year = df["year"] | ||
|
|
||
| # Inflation logic for ncdb. | ||
| inflate_cols = [ | ||
| "MDVALHS", | ||
| "MDGRENT", | ||
| "MDHHY", | ||
| ] | ||
| # Five rows have missing ncdb labels in variables.csv. | ||
| # per capita income, missing | ||
| # median household income white, missing | ||
| # median household income black, missing | ||
| # median household income hispanic, missing | ||
| # median household income asian, missing | ||
|
|
||
| inflate_available = list(set(df.columns).intersection(set(inflate_cols))) | ||
|
|
||
| if len(inflate_available): | ||
| df = adjust_inflation(df, inflate_available, year) | ||
| return df | ||
|
|
||
| #### End of New Code #### |
There was a problem hiding this comment.
this will need to work a little bit differently from the ltdb example. Unlike in the store_ltdb function, we've only got a single dataframe here, so we need to slice the ncdb dataframe by year and apply the adjust_inflation to each slice
|
Closing as this is now covered in #216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for your review of PR for Issue #59.
Verified that all ltdb variables that are affected by inflation adjustment are included in inflate_cols and the named strings match data from ltdb column of variables.csv. Function file data/data.py, line 494. I have checked every row of variables.csv file. There are no new variables for inflation adjustment. There are 8 variables that are affected by inflation adjustment.
Copied similar logic from ltdb inflate_cols into "store_ncdb" function definition. Use data from ncdb column in variables.csv. In data/data.py, see lines 678 - 701. Only 3 rows related to inflation adjustment have named strings in ncdb column. I am not sure if this logic works as desired. I added a definition for year, which is used in the last 2 lines.
Corrected several typos in documentation string part of data.py. ("dataframe" and "instantiation")
Thank you! Jennifer Yoon