Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch experiments with a new sample collector implemented in C.
The goal is to reimplement the sample collector, which is currently written in Rust. The committed version still lacks many features from the original implementation.
Why reimplement?
rustc
in most environments, especially in containers.gem install
, however that consumes a lot of time, and compilation is still slow.Of course I can improve these problems one by one, but given that C is the lingua franca of the Ruby community, I'd guessed that trying C wouldn't be that bad. And it wasn't (at least for now).
How to use
As pf2c still lacks many features, it is gated behind conditional compilation. Users must run
gem install
with the environment variablePF2_PF2C=1
. This will disable the originalPf2
, and in turn expose thePf2c
constant to Ruby.