Skip to content

skip snapshotting rootdir - #183

Merged
mzihlmann merged 1 commit into
mainfrom
layer-length-mismatch-v2
Aug 19, 2025
Merged

skip snapshotting rootdir#183
mzihlmann merged 1 commit into
mainfrom
layer-length-mismatch-v2

Conversation

@mzihlmann

@mzihlmann mzihlmann commented Aug 14, 2025

Copy link
Copy Markdown
Collaborator

Fixes GoogleContainerTools/kaniko#1375

Description

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

@mzihlmann
mzihlmann force-pushed the layer-length-mismatch-v2 branch 7 times, most recently from 9fc015d to 772748c Compare August 18, 2025 22:09
@mzihlmann
mzihlmann force-pushed the layer-length-mismatch-v2 branch from 772748c to c0f8a33 Compare August 18, 2025 22:13
@mzihlmann mzihlmann changed the title assume root-fs always exists skip snapshotting rootdir Aug 19, 2025
@mzihlmann
mzihlmann marked this pull request as ready for review August 19, 2025 07:02
@mzihlmann
mzihlmann merged commit 601d0f9 into main Aug 19, 2025
17 of 18 checks passed
@mzihlmann
mzihlmann deleted the layer-length-mismatch-v2 branch August 19, 2025 13:34
@mzihlmann

Copy link
Copy Markdown
Collaborator Author

should implement the same as GoogleContainerTools/kaniko#3425
let's compare the two solutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Layer tar files contain entry for root (/)

1 participant