Add denominations tree #5960
Add denominations tree #5960
Conversation
Added existing denomination presets from id-tagging-schema
There was a problem hiding this comment.
With a key like denomination that’s designed to be an enumeration of well-known values, rather than freeform text, id-tagging-schema still looks more promising to me as a mechanism for standardizing and localizing tags: openstreetmap/id-tagging-schema#254.
| }, | ||
| "items": [ | ||
| { | ||
| "displayName": "Kingdom Hall of Jehovah's Witnesses", |
There was a problem hiding this comment.
Many denominations translate their names into as many local languages as possible. The appropriate name usually varies by language more than by region. As it stands, id-tagging-schema is better suited to localization than NSI. This is already an issue for the flags tree, but the issue would be more acute for any denomination tree, because the icon usually wouldn’t be very clarifying to a non-English-speaker.
Or would we limit this tree to just the denominations that have a specialized name and icon for all their places of worship? These three presets only exist because it was considered inappropriate to use the ✝️ icon for these denominations.
There was a problem hiding this comment.
Yeah I was also thinking about how the displayNames for these denominations could be translated to a region's local language. I agree that id-tagging-schema would be a better place to have these presets because of these current limitations - I hadn't really thought about how the default presets are localized
Or would we limit this tree to just the denominations that have a specialized name and icon for all their places of worship?
This could work, though I can't think of any off the top of my head. I was also looking into how the denomination=mormon wiki page suggests to use operator tags to distinguish The Church of Jesus Christ of Latter-day Saints from other splinter groups. This particular case could work in NSI under the existing operator tree as localized operator values would be possible.
These three presets only exist because it was considered inappropriate to use the ✝️ icon for these denominations.
This makes sense now. I was wondering why there were only these three denomination presets
There was a problem hiding this comment.
I really don't want to introduce localization into the Name Suggestion Index display names. Display name is just the label that the preset shows in RapiD and JOSM.
But I think keeping this tree similar to how the flags tree works would be ok (denomination is an identifying value, and name can be whatever people want).
There was a problem hiding this comment.
But I think keeping this tree similar to how the
flagstree works would be ok (denominationis an identifying value, andnamecan be whatever people want).
#5982 tracks making flags localizable. Maybe the solution there could inform how we’d make denomination entries localizable too. But in the meantime, id-tagging-schema at least offers a way to localize the display names, even if it doesn’t have a straightforward way to filter denominations by religion (something we’d have to solve as part of this project too).
| @@ -0,0 +1,52 @@ | |||
| { | |||
| "properties": { | |||
| "path": "denominations/amenity/place_of_worship", | |||
There was a problem hiding this comment.
Besides places of worship, schools, community centers, and social facilities are often identified by their denomination as well. The editor would have to make sure not to “upgrade” something to a place of worship just because it has a matching denomination.
There was a problem hiding this comment.
That's a good point - I was thinking about adding schools to the denominations tree but left it out for now. IIRC iD only matches items of a different category if it falls into one of these matchGroups
There was a problem hiding this comment.
Yeah I think in this situation I think it should only offer to upgrade amenity/place_of_worship, or maybe also some generically tagged features like building=yes or amenity=yes when paired with a matching name or operator.
You'll need to change idgen.js too |
…into arch0345-denominations
So far I've just added denominations found in id-tagging-schema. If this gets merged we'll probably have to remove these presets from that repo.
Issues
The build script can't generate an
idwithout anamefor each entry in thedenominationstree. How are the transit/operator trees set up so that it can generate anidwithout having anametag?Closes #5232
Closes #6874