-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added list of abbreviations for addresses in English in Pakistan #2747
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for compiling the list. Just some observations from my side:
There are a couple of very generic terms in the list. They have limit use in the name search as currently implemented by Nominatim but they will increase the database quite a bit because they are so frequent. So I'd prefer to leave them out. These are: particles (between, opposite) and units (number, feet, mile, kilometer, etc.).
Also it is not necessary to repeat abbreviations that already appear in the generic English part (boulevard, street, road, etc.). Better to have a shorter list of abbreviations that are truly specific to Pakistan.
- Taluka -> Tehsil | ||
- Taluka Municipal Administration -> TMA | ||
- Tehsil -> Taluka | ||
- Tehsil Municipal Administration -> TMA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taluka and Tehsil appear to be synonyms rather than abbreviation forms. Nominatim doesn't have a proper handling for that yet, but the abbreviation list is not the best place.
Thank you for your feedback - good to know about the common words and overlapping abbreviations, I will revise to be more specific. Are some of the common ones that are abbreviated in a very short form often in Pakistan still acceptable? For example, Taluka and Tehsil are synonyms yes, I was on the fence about including it. I do try to add both to the Wikidata "other forms" fields where applicable, or to |
Looking at the current Pakistan data, there is a clear use for 'block' and 'sector'. It make sense to leave that in. The few usages of 'floor' are rather questionable and will be filtered out by Nominatim (Example: the housenumber in this node). In all examples I saw, the tag 'house' is a bit of a mixed case. There are quite a few uses but I suspect that in many cases the abbreviation shouldn't be used, e.g. for White House Grammar School. I'd rather be on the conservative side for the moment and leave it out, too. We can revisit the decision later. Regarding Taluka and Tehsil, adding |
You can take a look at some business directories like these to see how they are used in addresses:
https://www.dibpak.com/wp-content/uploads/2020/01/DubaiIslamicBank-Branch-Contact-Directory-Jan-2020_.pdf
https://psopk.com/files/station_finder/list_of_stations.pdf
I tried to make sure the terms in the YAML are all forms it makes sense for a geocoder to expand, some of the terms you see in the address listing above may look abbreviation-like but are not abbreviations or refer to places more specific than would be common in addresses. Let me know if you have any questions