update eslint to v9

eslint.config.mjs

@@ -0,0 +1 @@
+export { default } from 'eslint-config-kyle';

package.json

@@ -24,31 +24,18 @@
  "@types/react": "^18.2.18",
  "@types/react-dom": "^18.2.7",
  "@vitejs/plugin-react": "^4.0.4",
- "eslint": "^8.56.0",
- "eslint-config-kyle": "^17.0.2",
+ "eslint": "^9.9.0",
+ "eslint-config-kyle": "^25.0.0-beta2",
  "typescript": "^5.1.6",
  "vite": "^4.4.8",
  "vitest": "^0.34.6"
  },
  "scripts": {
- "lint": "eslint --ext .ts,.tsx,.js --ignore-path .gitignore . && tsc",
+ "lint": "eslint . && tsc",
  "test": "vitest",
  "start": "vite",
  "build": "vite build"
  },
- "eslintConfig": {
- "extends": "kyle",
- "settings": {
- "jest": {
- "version": 28
- }
- },
- "rules": {
- "unicorn/no-unreadable-array-destructuring": "off",
- "@typescript-eslint/no-dynamic-delete": "off",
- "no-lonely-if": "off"
- }
- },
  "prettier": "eslint-config-kyle/prettier",
  "browserslist": [
  ">0.2%",

src/index.tsx

@@ -13,6 +13,7 @@ import './index.css';
 
 const getCurrentRoute = () => window.location.hash.slice(1);
 
+// eslint-disable-next-line no-useless-assignment -- false positive
 const App: React.FC = () => {
  const [path, setPath] = useState<string>(getCurrentRoute());
 

src/pages/HistoryRestorer/HistoryRestorer.tsx

@@ -222,7 +222,6 @@ const HistoryRestorerInner: React.FC = () => {
  <br />
  <br />
  Logged in as <code>{user.display_name}</code>.{' '}
- {/* eslint-disable-next-line jsx-a11y/no-static-element-interactions, jsx-a11y/anchor-is-valid */}
  <a onClick={logout}>Logout</a>
  </div>
  );

src/pages/addressImport/AddressProgressChart.tsx

@@ -47,7 +47,7 @@ export const AddressProgressChart: React.FC = () => {
  // .filter((cat) => cat !== 'PERFECT' && cat !== 'TOTALLY_MISSING')
  .map(([_addressCategory, categoryInfo]): Serie => {
  const addressCategory = _addressCategory as AddressCategory; // TS is dumb
- const [, , , colour] = categoryInfo;
+ const colour = categoryInfo[3];
 
  return {
  id: addressCategory,

src/pages/upload/Upload.tsx

@@ -298,7 +298,6 @@ const UploadInner: React.FC = () => {
  <br />
  <div style={{ display: 'flex', gap: 16 }}>
  <div>
- {/* eslint-disable-next-line jsx-a11y/label-has-associated-control -- rule broken */}
  <label>
  <input
  type="checkbox"

src/pages/upload/components/DiffForFeature.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable jsx-a11y/control-has-associated-label */
 import { useContext, useMemo } from 'react';
 import TimeAgo from 'react-timeago-i18n';
 import type { OsmFeature } from 'osm-api';

src/pages/upload/createOsmChangeFromPatchFile.ts

@@ -13,6 +13,7 @@ import type { OsmPatch } from '../../types';
 import { type FetchCache, fetchChunked } from './util';
 import { type Bbox, getGeoJsonBbox } from './helpers/bbox';
 
+// eslint-disable-next-line unicorn/prefer-structured-clone
 window.structuredClone ||= (x) => JSON.parse(JSON.stringify(x));
 
 const TEMPLATE_OSM_FEATURE: Omit<OsmFeature, 'id' | 'type'> = {

src/pages/upload/helpers/bbox.ts

@@ -49,6 +49,7 @@ export function getGeoJsonBbox(osmPatch: OsmPatch): Bbox {
  const allCoords: number[] = [];
  for (const f of osmPatch.features) {
  if ('coordinates' in f.geometry) {
+ // eslint-disable-next-line unicorn/no-magic-array-flat-depth -- Position[][][] -> Position
  const flatCoords = f.geometry.coordinates.flat(3);
  allCoords.push(...flatCoords);
  }

src/wrappers/AuthGateway.tsx

@@ -13,6 +13,7 @@ type IAuthContext = {
  logout(): void;
 };
 export const AuthContext = createContext({} as IAuthContext);
+AuthContext.displayName = 'AuthContext';
 
 export const AuthGateway: React.FC<PropsWithChildren> = ({ children }) => {
  const [error, setError] = useState<Error>();

vite.config.ts

@@ -1,7 +1,5 @@
-/* eslint-disable import/no-extraneous-dependencies */
 import { defineConfig } from 'vitest/config';
 import react from '@vitejs/plugin-react';
-/* eslint-enable import/no-extraneous-dependencies */
 
 // https://vitejs.dev/config/
 export default defineConfig({