Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uv support #334

Merged
merged 7 commits into from
Feb 8, 2025
Merged

Adds uv support #334

merged 7 commits into from
Feb 8, 2025

Conversation

tanishy7777
Copy link
Contributor

@tanishy7777 tanishy7777 commented Jan 31, 2025

Fixes #329

Adds uv support

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Building using uv
image
image

@Anavelyz
Copy link
Collaborator

Anavelyz commented Feb 5, 2025

Thank you for working on it. I will check it later, sorry for the delay in feedback.

@tanishy7777
Copy link
Contributor Author

Thank you for working on it. I will check it later, sorry for the delay in feedback.

No worries

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @tanishy7777 ... thank you so much for working on that.
lgtm, I just found an issue in the Makefile .. other than that, it looks great.

@tanishy7777
Copy link
Contributor Author

hi @tanishy7777 ... thank you so much for working on that. lgtm, I just found an issue in the Makefile .. other than that, it looks great.

Made the changes

@xmnlab
Copy link
Member

xmnlab commented Feb 8, 2025

great job, @tanishy7777 ! appreciate that.

@xmnlab xmnlab merged commit 33fd0bd into osl-incubator:main Feb 8, 2025
20 checks passed
Copy link

github-actions bot commented Feb 8, 2025

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tanishy7777
Copy link
Contributor Author

great job, @tanishy7777 ! appreciate that.

Happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support to uv in build system
3 participants