Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: flat to src layout #63

Merged
merged 2 commits into from
Nov 24, 2023
Merged

refactor: flat to src layout #63

merged 2 commits into from
Nov 24, 2023

Conversation

abhijeetSaroha
Copy link
Collaborator

@abhijeetSaroha abhijeetSaroha commented Nov 23, 2023

This PR aims to move from flat-layout to src-layout.

Solve #61

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for working on that

pyproject.toml Outdated
".gitignore",
"Makefile",
]
include = ["src/makim/*"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
include = ["src/makim/*"]
packages = [
{include = "makim", from="src"},
]
include = ["src/makim/py.typed"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a src/makim/py.typed file, as an empty file

@abhijeetSaroha
Copy link
Collaborator Author

I have created the src.makim/py.typed file, an empty file. I think it works fine, can you please verify it?

Copy link
Member

@xmnlab xmnlab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhijeetSaroha , LGTM! thanks for working on that!

@xmnlab xmnlab changed the title WIP: flat to src layout refactor: flat to src layout Nov 24, 2023
@xmnlab xmnlab merged commit fbb2b67 into osl-incubator:main Nov 24, 2023
8 checks passed
Copy link

github-actions bot commented Dec 8, 2023

🎉 This PR is included in version 1.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants