Add CAPI 1.33 image #1297
Open
Add CAPI 1.33 image #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christian Berendt <[email protected]>
|
Depends on osism/k8s-capi-images#278 |
![codereviewbot-ai[bot]](https://avatars.githubusercontent.com/in/309638?s=60&v=4){kind=small}
| @@ -12,7 +12,7 @@ | |||
| from osism.data import TEMPLATE_IMAGE_CLUSTERAPI, TEMPLATE_IMAGE_OCTAVIA | |||
| from osism.tasks import openstack, handle_task | |||
|
|
|||
| SUPPORTED_CLUSTERAPI_K8S_IMAGES = ["1.30", "1.31", "1.32"] | |||
| SUPPORTED_CLUSTERAPI_K8S_IMAGES = ["1.30", "1.31", "1.32", "1.33"] | |||
There was a problem hiding this comment.
The list of supported Kubernetes versions for ClusterAPI is hardcoded (SUPPORTED_CLUSTERAPI_K8S_IMAGES). This approach can limit flexibility and increase maintenance overhead when versions need to be added or removed. Consider externalizing these values to a configuration file or fetching them dynamically from an API to enhance maintainability and adaptability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.