Fix makefile f2py compatibility issues
#12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provided 2 fixes for
f2pyissues in installation.FPdefaulted tof2py(instead off2py3.8, and can be optionally overridden by users with environment variable, e.g.,f2py3.8is specific for Python 3.8 . Furthermore, in some environment, e.g., conda-based Linux, onlyf2pyis provided.f2pyfrom numpy 1.26.4, it no longer accepts the command line arguments, and generates error.$ make f2py -c -m --quiet pyaneti src/constants.f90 src/todo.f90 src/qpower2.f90 src/quad.f90 src/ftr.f90 src/frv.f90 src/bayesian.f90 src/matrices.f90 src/kernels.f90 src/mcmc.f90 src/multi-gp-routines.f90 --fcompiler=gnu95 -llapack -lblas --compiler=unix usage: f2py [--dep DEPENDENCIES] [--backend {meson,distutils}] [-m MODULE_NAME] f2py: error: argument -m: expected one argument make: *** [makefile:41: pyaneti] Error 2The second fix moves
-mto be immediately beforepyaneti, so that it is accepted by f2py in numpy 1.26.4, as well as older versions (tested in 1.26.0 and 1.23.5)# location of -m is moved f2py -c --quiet -m pyaneti src/constants.f90 ...