Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helpers: remove empty customization fields [COMPOSER-2204] #2010

Closed
wants to merge 1 commit into from

Conversation

jkozol
Copy link
Collaborator

@jkozol jkozol commented May 15, 2024

Customizations that contain empty arrays or objects instead of being undefined cause failed image builds even with a valid blueprint.

The clean function recursively removes this empty fields from the blueprint object and fixes the edge image build failures.

Copy link

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no context to the project so take what I say with a huge grain of salt - I wonder if this should have a test?

@jkozol jkozol changed the title helpers: remove empty customization fields helpers: remove empty customization fields [COMPOSER-2204] Jun 2, 2024
@jkozol jkozol force-pushed the edgeFix branch 2 times, most recently from 4630e41 to acbb436 Compare June 2, 2024 23:21
Customizations that contain empty arrays or objects instead of being
undefined cause failed image builds even with a valid blueprint.

The clean function recursively removes this empty fields from the
blueprint object and fixes the edge image build failures.
Copy link

github-actions bot commented Jul 3, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jul 3, 2024
Copy link

This PR was closed because it has been stalled for 30+7 days with no activity.

@github-actions github-actions bot closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants