openqa-trigger-bisect-jobs: Also evaluate "exclude_name_regex" #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
b10n1k
reviewed
Apr 28, 2025
b10n1k
reviewed
Apr 28, 2025
Martchus
reviewed
Apr 28, 2025
b10n1k
reviewed
Apr 28, 2025
b10n1k
reviewed
Apr 28, 2025
okurz
force-pushed
the
feature/bisect_name_regex
branch
3 times, most recently
from
223319a to
b0f9480
Compare
Sorry, I removed unrelated changes. This PR should be only about introducing exclude_name_regex |
It was observed that openqa-trigger-bisect-jobs were triggered even though according openqa-investigate jobs were not as the variable "exclude_name_regex" would exclude the job. However unlike "exclude_group_regex" the variable "exclude_name_regex" so far was only evaluated within openqa-investigate, not openqa-trigger-bisect-jobs. This commit adds according handling within openqa-trigger-bisect-jobs with according unit test.
okurz
force-pushed
the
feature/bisect_name_regex
branch
from
b0f9480 to
156a48d
Compare
Done in |
Martchus
approved these changes
Apr 29, 2025
perlpunk
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was observed that openqa-trigger-bisect-jobs were triggered even
though according openqa-investigate jobs were not as the variable
"exclude_name_regex" would exclude the job. However unlike
"exclude_group_regex" the variable "exclude_name_regex" so far
was only evaluated within openqa-investigate, not
openqa-trigger-bisect-jobs. This commit adds according handling within
openqa-trigger-bisect-jobs with according unit test.