Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update CONTRIBUTING & COC #148

Merged
merged 6 commits into from
Jun 22, 2022
Merged

docs: update CONTRIBUTING & COC #148

merged 6 commits into from
Jun 22, 2022

Conversation

vinckr
Copy link
Member

@vinckr vinckr commented Jun 16, 2022

  • docs: update CONTRIBUTING.md + COC

Update CONTRIBUTING to add a section about adding new examples
update CONTRIBUTING to reflect the new Ory docs structure
update CONTRIBUTING with some language fixes and removing redundant info

update COC template from version 1.4. to 2.1

@vinckr vinckr marked this pull request as ready for review June 16, 2022 10:14
@kevgo
Copy link
Contributor

kevgo commented Jun 22, 2022

I think the version of the Check format CI job is out of sync with the version of our shared Prettier config that this repo is formatted with. The repo uses ory-prettier-config v1.2.0, the CI job is stuck at v1.0.1.

#152 fixes this once and for all by making CI use the exact same Prettier configuration that npm run format uses.

@aeneasr
Copy link
Member

aeneasr commented Jun 22, 2022

LGTM but needs the conflicts to be resolved :)

@aeneasr
Copy link
Member

aeneasr commented Jun 22, 2022

@vinckr vinckr requested a review from aeneasr June 22, 2022 14:28
@aeneasr aeneasr merged commit 8a3d371 into master Jun 22, 2022
@aeneasr aeneasr deleted the update-contributing branch June 22, 2022 15:12
@vinckr vinckr mentioned this pull request Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants