Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names of neurodata_types, assigned names, and corresponding code #49

Merged
merged 13 commits into from
Feb 29, 2020

Conversation

oruebel
Copy link
Owner

@oruebel oruebel commented Feb 29, 2020

Fix #32
Fix #27

This PR:

  • Rename sweeps to simultaneous_recordings
  • Rename Sweeps to SimultaneousRecordingsTable
  • Rename sweep_sequence to sequential_recordings
  • Rename SweepSequence to SequentialRecordingsTable
  • Rename runs to repetitions
  • Rename Runs to RepetitionsTable
  • Rename conditions to experimental_conditions
  • Rename Conditions to ExperimentalConditionsTable

For this refactoring this PR updates:

  • The type definitions and assigned names in the specification
  • The icephys container classes and associated functions to follow the new naming conventions
  • The icephys tests to work with the new function/parameter/argument names
  • The example notebooks to work with the new function/parameter/argument names
  • The example in the README to work with the new function/parameter/argument names

@oruebel oruebel merged commit 48b0d9f into master Feb 29, 2020
@oruebel oruebel deleted the update/tyepnames branch February 29, 2020 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define more descriptive names for the tables Rename table types to end in Table
1 participant