Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: com.apple.application-identifier needs a period #308

Open
wants to merge 1 commit into
base: zkat/file-provider-macos
Choose a base branch
from

Conversation

janl
Copy link
Contributor

@janl janl commented Oct 27, 2023

There are two issues:

  1. the value for the application-identifier entitlement is missing a period
  2. the oro binary is not signed with the entitlements file

after applying the PR, run:

# rebuild
cargo build

# sign with entitlements
codesign -s - -f --entitlements crates/alabaster/src/macos/alabaster-swift/Sources/alabaster-swift/AlabasterSwift.entitlements target/debug/oro
target/debug/oro: replacing existing signature

# validate signature
codesign -d --entitlements - --xml target/debug/oro
Executable=/Users/jan/Work/rust/orogene/target/debug/oro
<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "https://www.apple.com/DTDs/PropertyList-1.0.dtd"><plist version="1.0"><dict><key>com.apple.application-identifier</key><string>$(AppIdentifierPrefix).$(PRODUCT_BUNDLE_IDENTIFIER)</string><key>com.apple.security.app-sandbox</key><true/><key>com.apple.security.application-groups</key><array></array></dict></plist>

# now
> ./target/debug/oro mount
Trace/BPT trap: 5

note that cargo run mount will re-build and re-sign the binary to before our change, so this should really be part of the build process.

Now the new error is also not great, but a step forward.

@zkat
Copy link
Member

zkat commented Oct 27, 2023

Where does PRODUCT_BUNDLE_IDENTIFIER come from??

@janl
Copy link
Contributor Author

janl commented Oct 27, 2023

Normally from an app’s Info.plist. I’m not 100% sure how this works for not-really-apps. I’ll do some digging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants