Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QoL] Reformatting source code and enable pre-commit ci #60

Merged
merged 14 commits into from
Aug 26, 2024
Merged

Conversation

KedoKudo
Copy link
Contributor

Description of Pull Request

This PR introduces the following changes:

  • Use clang-format pipeline to auto reformat source code (and fix typos)
  • Enable pre-commit ci as part of the check
  • Re-enable Mac build for Apple m chip

Purpose of work

This is QoL PR that aims to improve the code and ci quality.

Summary of work

N/A

Additional detail of work

N/A

Testing instructions

No feature changes, pipeline testing should be sufficient.

Fixes #34.

@KedoKudo KedoKudo self-assigned this Aug 26, 2024
Copy link

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only looked at the .pre-commit-config.yaml which looks standard

@KedoKudo KedoKudo merged commit 1324c38 into next Aug 26, 2024
2 checks passed
@KedoKudo KedoKudo deleted the pre-commit branch August 26, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit to CI
2 participants