Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calls to param's API #300

Merged
merged 6 commits into from
Jun 13, 2024
Merged

Update calls to param's API #300

merged 6 commits into from
Jun 13, 2024

Conversation

jmborr
Copy link
Collaborator

@jmborr jmborr commented Jun 6, 2024

No description provided.

@jmborr jmborr self-assigned this Jun 6, 2024
@KedoKudo KedoKudo self-requested a review June 13, 2024 16:53
KedoKudo
KedoKudo reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@KedoKudo KedoKudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests are fixed now, if we can get the doc to build, the rest of the PR is good to go.

@KedoKudo KedoKudo merged commit f76e6fd into next Jun 13, 2024
6 checks passed
@KedoKudo KedoKudo deleted the param2 branch June 13, 2024 17:52
@ktactac-ornl ktactac-ornl restored the param2 branch June 13, 2024 19:47
@ktactac-ornl ktactac-ornl mentioned this pull request Jun 13, 2024
Merged
KedoKudo added a commit that referenced this pull request Jun 13, 2024
@KedoKudo
Merge pull request #301 from ornlneutronimaging/param2
9ef5123 
Supplement to #300
@ktactac-ornl ktactac-ornl mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KedoKudo KedoKudo KedoKudo approved these changes

Assignees

@jmborr jmborr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmborr @KedoKudo @dmitry-ganyushin @ktactac-ornl