Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Beam hardening correction function to correction module #293

Merged
merged 13 commits into from
Feb 19, 2024

Conversation

KedoKudo
Copy link
Contributor

@KedoKudo KedoKudo commented Feb 15, 2024

This PR introduces the following changes:

  • Add a new wrapper for the beam hardening correction for functions from algotom
  • Add a unit test with synthetic data (no reference data provided from the instrument team). This unit test should be updated with real experiment data
    • img_with_beamhardening -> ref_img_beamhardening_corrected
    • img_without_beamhardening -> img_without_beamhardening
  • Build system is updated to match the new standard.
  • Add cap for some dependencies as the newer version has API breaking changes that leads to multiple test failures.

EWM: Story3866

@KedoKudo KedoKudo self-assigned this Feb 15, 2024
@KedoKudo KedoKudo force-pushed the add_beamhardending_corr branch from 5da2d16 to 924780f Compare February 15, 2024 19:28
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (551427f) 94.84% compared to head (750af05) 94.83%.
Report is 1 commits behind head on next.

Files Patch % Lines
src/imars3d/backend/corrections/beam_hardening.py 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #293      +/-   ##
==========================================
- Coverage   94.84%   94.83%   -0.02%     
==========================================
  Files          20       21       +1     
  Lines        1203     1239      +36     
==========================================
+ Hits         1141     1175      +34     
- Misses         62       64       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KedoKudo KedoKudo merged commit 707c7f6 into next Feb 19, 2024
8 checks passed
@KedoKudo KedoKudo deleted the add_beamhardending_corr branch February 19, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants