Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable keep alives to not keep dead connections #1036

Closed
wants to merge 1 commit into from

Conversation

karelbilek
Copy link
Contributor

Fixes #1035

@orlangure
Copy link
Owner

Hey @karelbilek and thanks for working on this.

I'm not sure this will work with every possible configuration of remote docker, custom socket names and all that. It might, but I don't have a deep enough understanding of that to make sure it will always work.

Your second idea in the attached issue was to call Close on the client. I think it's a much safer and better option. There aren't many places that create a new client, so adding a simple defer shouldn't be an issue. What do you think?

@karelbilek
Copy link
Contributor Author

Closed in favor of #1041

@karelbilek karelbilek closed this May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: leaking goroutines
2 participants