Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] fix compile error in the MWMTextToSpeechTest #8273

Merged

Conversation

kirylkaveryn
Copy link
Contributor

This pr fixes the error in some xcodes:

/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS17.2.sdk/usr/include/c++/v1/__algorithm/find.h:25:18 

Invalid operands to binary expression ('std::pair<std::string, std::string>' and 'const std::pair<const char *, const char *>')

@kirylkaveryn kirylkaveryn added the Build Compilation issue label May 24, 2024
Signed-off-by: Kiryl Kaveryn <[email protected]>
@kirylkaveryn kirylkaveryn force-pushed the ios/fix-types-compile-error-in-MWMTextToSpeechTrsts branch from ad78d39 to ffe7e4b Compare May 24, 2024 12:44
@rtsisyk
Copy link
Member

rtsisyk commented May 24, 2024

This pr fixes the error in some xcodes:

/Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS17.2.sdk/usr/include/c++/v1/__algorithm/find.h:25:18 

Invalid operands to binary expression ('std::pair<std::string, std::string>' and 'const std::pair<const char *, const char *>')

Why has it leaked through CI? Do we use a different version for iOS Check / Build iOS (Release)?

@kirylkaveryn
Copy link
Contributor Author

kirylkaveryn commented May 24, 2024

Why has it leaked through CI? Do we use a different version for iOS Check / Build iOS (Release)?

Maybe my Xcode 15.2 is outdated and cannot parse it. CI uses 15.3.
I prefer not to update the Xcode and ios on my device during the app releasing :)

@rtsisyk
Copy link
Member

rtsisyk commented May 24, 2024

Why has it leaked through CI? Do we use a different version for iOS Check / Build iOS (Release)?

Maybe my Xcode 15.2 is outdated and cannot parse it. CI uses 15.3. I prefer not to update the Xcode and ios on my device during the app releasing :)

OK, thanks for investigatng. I doubt that we want to test both 15.2 and 15.3 in CI. Let's see if similar issues occur in the future. I don't remember previous precedents.

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Дзякуй!

@biodranik biodranik merged commit c1fbbd0 into master May 24, 2024
5 checks passed
@biodranik biodranik deleted the ios/fix-types-compile-error-in-MWMTextToSpeechTrsts branch May 24, 2024 21:07
@fabwu
Copy link
Contributor

fabwu commented May 25, 2024

@kirylkaveryn That's strange. I'm quite sure I run the tests before pushing. I'm using 15.3 for development so you might be right about the SDK version causing this problem...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Compilation issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants