Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app screenshots with latest UI #8120

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jean-BaptisteC
Copy link
Member

@Jean-BaptisteC Jean-BaptisteC commented May 8, 2024

This PR is a temporary solution, while we wait development to generate automatically app screenshots.

  • I have already worked on app screenshots on the website (Add new screenshots with latest feature organicmaps.github.io#145), but I have wasted a lot of time generating exactly which screenshots you want.
  • I have tried to do the same screenshots but the styles are very different from the start and it seems the device used for the first screenshots has a quad HD resolution.
  • The size of screenshots is different, I have tried to resize but the looks are not good.
  • Screenshots are in full quality, not compressed

Todo:

  • Add tablet screenshots

Google Guidelines

@biodranik
Copy link
Member

Thanks! What are Google Play requirements? Which resolutions are missing? How many screenshots are possible? Is there a way to also add a video screen recording (a short features demo for example)?

@rtsisyk
Copy link
Contributor

rtsisyk commented May 9, 2024

@Jean-BaptisteC thanks for the contribution!!

It would be nice to match the sizes and resolutions of the previous images.

@Jean-BaptisteC
Copy link
Member Author

I don't have device with Quad HD resolution :)

@biodranik
Copy link
Member

Can simulator be used for that? A beta build should not print debug info.

@Jean-BaptisteC
Copy link
Member Author

There are no emulators with the same resolution.

@rtsisyk
Copy link
Contributor

rtsisyk commented May 10, 2024

I don't remember exactly how I made existing screenshots, but probably also by using emulators.

@rtsisyk
Copy link
Contributor

rtsisyk commented May 10, 2024

I will really appreciate it if you could make one more attempt to create new screenshots with the highest possible resolution. If not, I don't see any blockers with merging this PR.

@Jean-BaptisteC
Copy link
Member Author

Old screenshots has been made with Samsung phone

@biodranik
Copy link
Member

There are no emulators with the same resolution.

I saw an option to create a custom device with a custom resolution in the Emulator. Won't it work?

@Jean-BaptisteC
Copy link
Member Author

Jean-BaptisteC commented May 10, 2024

I can try with custom resolution, but screenshots in Quad HD doesn't take all space of screen, when we check screenshots from Play store.
You can compare on your mobile, these apps

FIY, add videos on play store requires videos are on youtube.

@biodranik
Copy link
Member

As far as we meet Google Play requirements, and screenshots looks good in store on different devices, it should be fine:
https://support.google.com/googleplay/android-developer/answer/9866151?hl=en#zippy=%2Cscreenshots

Requirements

To publish your store listing, you must provide a minimum of two screenshots across form factors that meet the following requirements:

    JPEG or 24-bit PNG (no alpha)
    Minimum dimension: 320px
    Maximum dimension: 3840px 
        The maximum dimension of your screenshot can't be more than twice as long as the minimum dimension.

Highly recommended

    Some sections of Google Play show groups of recommended apps and games in a large format using screenshots. To be eligible for recommendations in formats that use screenshots, the following guidelines are a requirement:
        For apps, you must provide at least four screenshots with minimum 1080px resolution. These should be 16:9 for landscape (minimum 1920x1080px) screenshots and 9:16 for portrait screenshots (minimum 1080x1920px).
        For games you must provide at least three 16:9 landscape screenshots (minimum 1920x1080px) or three 9:16 portrait screenshots (minimum 1080x1920px). Make sure that these screenshots depict the in-game experience so users can get a sense of what the gameplay will be like if they download and play
    Screenshots must demonstrate the actual in-app or in-game experience, focusing on the core features and content so users can anticipate what the app or game experience will be like.
        Use captured footage of the app or game itself. Do not include people interacting with the device (for example, fingers tapping on the device), unless the core gameplay or app usage is off-device.
    Stylized screenshots that break UI across multiple uploaded images are allowed, but prioritize UI in the first three screenshots as much as possible.
Large screens:

    For Chromebook and tablets, you can add a minimum of 4 screenshots to demonstrate your in-app experience.
    Upload screenshots between 1,080 and 7,680px
    Use a 16:9 aspect ratio for landscape and a 9:16 aspect ratio for portrait
    Exclude additional text that is not part of your core app experience, as this can get cut off on Play homepages on certain screen sizes
    Don't forget to optimize your app quality for large screens by [reviewing our app quality checklist](https://developer.android.com/distribute/googleplay/quality/tablet.html)

@rtsisyk
Copy link
Contributor

rtsisyk commented May 15, 2024

The new screenshots met Google's requirements. However, they have lower resolutions than the previous version. I think that the higher resolution we upload to Google Play is better.

Signed-off-by: Jean-BaptisteC <[email protected]>
@Jean-BaptisteC
Copy link
Member Author

I have created an emulator with custom dimensions and I have generated new screenshots.
But it's not easy, because I need to use an app to do native screenshots and Organic Maps crash few seconds after start routing :(
Please review

@biodranik
Copy link
Member

@Jean-BaptisteC wow, what kind of crash? Let's fix it.

Copy link
Member

@biodranik biodranik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @rtsisyk can you please double check so these screenshots will be properly updated in every store?

@Jean-BaptisteC is it possible to automate screenshots creation for different languages?

@Jean-BaptisteC
Copy link
Member Author

I have this error few second after routing has started. I use Pixel 6 pro like emulator. I have 4 Go of RAM

2024-05-18 21:35:53.507  2345-2724  OMcore app.organicmaps.web  E vulkan/vulkan_object_manager.cpp:347 FlushUnsafe(): CHECK(statusCode == VK_SUCCESS) Vulkan error: vkFlushMappedMemoryRanges(m_device, 1, &mappedRange) finished with code VK_ERROR_OUT_OF_HOST_MEMORY
2024-05-18 21:35:53.507  2345-2724  libc app.organicmaps.web A Fatal signal 6 (SIGABRT), code -1 (SI_QUEUE) in tid 2724 (Thread-19), pid 2345 (organicmaps.web)

@biodranik
Copy link
Member

@Jean-BaptisteC does it also reproduce with these changes? #8139

@Jean-BaptisteC
Copy link
Member Author

I want finish this PR, for tablet do you want ?

  • Landscape screenshots
  • Portrait screenshots
  • Landscape + portrait screenshots (It's already the case on Play Store)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants