Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[android-auto] New UI #8019

Merged
merged 1 commit into from May 16, 2024
Merged

[android-auto] New UI #8019

merged 1 commit into from May 16, 2024

Conversation

AndrewShkrob
Copy link
Member

Screenshot 2024-04-27 at 23 44 54 Screenshot 2024-04-27 at 23 44 45

@AndrewShkrob AndrewShkrob added the AndroidAuto Android Auto label Apr 27, 2024
@AndrewShkrob AndrewShkrob changed the title Android auto/new UI [android-auto] New UI Apr 27, 2024
Jean-BaptisteC
Jean-BaptisteC requested changes Apr 28, 2024
View reviewed changes
Copy link
Member

@Jean-BaptisteC Jean-BaptisteC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Pixel 6 - Android 14 + AA Emulator

Search a place to start routing doesn't work -> panel routing doesn't appears
Settings button is present at the side of cross button in freedrive mode

@AndrewShkrob
Copy link
Member Author

AndrewShkrob commented Apr 28, 2024 •
edited

❌ Pixel 6 - Android 14 + AA Emulator

Search a place to start routing doesn't work -> panel routing doesn't appears
Settings button is present at the side of cross button in freedrive mode

These changes are based on #8015
The PR contains only UI changes, so no need to test any logic under this PR.

Search a place to start routing doesn't work -> panel routing doesn't appears

Should be fixed under #8015

Settings button is present at the side of cross button in freedrive mode

It is an intended behaviour.

@biodranik biodranik added this to the Needs alpha/beta testing milestone Apr 28, 2024
@biodranik
Copy link
Member

@rtsisyk @Jean-BaptisteC Is it ready for release?

@Jean-BaptisteC
Copy link
Member

Needs more tests

@rtsisyk
Copy link
Contributor

rtsisyk commented May 16, 2024

Needs more tests

I plan to test it.

@rtsisyk
Copy link
Contributor

rtsisyk commented May 16, 2024

I have tested this change in my car on real hardware, and it worked very well. Thanks for improving UI!!

@rtsisyk
Copy link
Contributor

rtsisyk commented May 16, 2024

@AndrewShkrob could you please rebase this PR and I will push it.

@rtsisyk rtsisyk removed this from the Needs alpha/beta testing milestone May 16, 2024
@AndrewShkrob
[android-auto] New UI
99b94a6 
Signed-off-by: Andrew Shkrob <[email protected]>
@rtsisyk rtsisyk merged commit 93db820 into organicmaps:master May 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jean-BaptisteC Jean-BaptisteC Jean-BaptisteC requested changes

@rtsisyk rtsisyk rtsisyk approved these changes

@biodranik biodranik Awaiting requested review from biodranik

Assignees
No one assigned
Labels
AndroidAuto Android Auto
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@AndrewShkrob @biodranik @Jean-BaptisteC @rtsisyk