[android] Implements exit button in navigation notification #7953

kavikhalique · 2024-04-18T20:52:29Z

Fixes #7492
Implements Exit button in navigation notification

Use Case -
1 - If user clicks on exit navigation in background of app it simply stops navigation and closes the notification
2 - If user clicks the button while app is in foreground it works similar to pressing the stop button in bottom navigation of navigation screen

What I changed -
I added one button in notification and attached a pending intent with the button. Pending intent runs once the exit button gets clicked. It triggers cancel() method inside RoutingController.java class which basically stops the navigation which is going on. Then it triggers another method stopself() which closes the notification.

Screenshots-

Sample Video -

fix4.mp4

biodranik

Thanks!

android/app/src/main/java/app/organicmaps/routing/NavigationService.java

RedAuburn · 2024-04-19T10:04:54Z

Tried it out and found an issue:

start routing with vehicle mode
move app to background
press exit button in notification
re-open app

Result:
routing has stopped correctly, but the vehicle map style is still used. (it should be the default clear style)

kavikhalique · 2024-04-19T10:19:46Z

Tried it out and found an issue:

start routing with vehicle mode

move app to background

press exit button in notification

re-open app

Result:

routing has stopped correctly, but the vehicle map style is still used. (it should be the default clear style)

Thanks, I missed that. Will correct it soon.

Jean-BaptisteC · 2024-04-19T10:56:26Z

You can use same method used on stop button in navigation bottom bar

kavikhalique · 2024-04-19T11:01:47Z

You can use same method used on stop button in navigation bottom bar

Yes sir, but the issue is that there is a container class which contains all the methods and in background it becomes null because it has been defined inside mwmActivity.java class.

I was thinking to create a shared preference variable which will be set to true if notification will be exited from background and then whenever activity will resume in foreground it will check the value of shared preference and if it will be true it will trigger the stop button method of navigationController.

biodranik · 2024-04-19T11:09:22Z

Is it possible to call the same methods that are called by pressing the stop button in the nav panel?

kavikhalique · 2024-04-19T11:39:57Z

Is it possible to call the same methods that are called by pressing the stop button in the nav panel?

Yes sir, I am calling the same method but whenever that method is triggered from background of navigation activity it does not updates the map activity to default.

Trying to figure it out where things are actually changing.

kavikhalique · 2024-04-19T14:50:57Z

Fixed the issue of UI updation after exiting navigation from background of app.

What i did -

Used Shared preferences to check if app is in background or foreground and accordingly called methods after coming in foreground which were not available when app was in background.

Please review it - @Jean-BaptisteC @RedAuburn

kavikhalique · 2024-04-20T09:26:33Z

Please sir review my changes and if there is any changes required please inform me. @rtsisyk @biodranik

biodranik

Is it the only/cleanest way to fix the issue?

kavikhalique · 2024-04-20T09:38:17Z

Is it the only/cleanest way to fix the issue?

I have gone through OSMAnd's code base for exit button they have created a broadcast receiver and they have a separate class which determines the mode of application and then according to foreground or background mode actions are taken.

Since I didn't found any such class to determine the mode of app i used shared preference.

I feel better and cleaner ways exist.

kavikhalique · 2024-04-23T08:57:46Z

Sir please review it and if there is any suggestions please disscuss so that i can correct it @rtsisyk

rtsisyk · 2024-04-24T14:25:51Z

Sir please review it and if there is any suggestions please disscuss so that i can correct it @rtsisyk

I will take a look. Sorry for the delay!!

rtsisyk

Thanks for your contribution, and sorry for the delay with the code review. 🙏

Could you please evaluate the idea of routing STOP_NAVIGATION intent via MwmActivity to eliminate the need of using IS_CANCELLED_FROM_BACKGROUND flag in Preferences (see a comment inline)? I think it would make the code even much simpler.

rtsisyk · 2024-04-26T10:31:53Z

android/app/src/main/java/app/organicmaps/MwmActivity.java

@@ -2186,4 +2190,19 @@ public void onTrimMemory(int level)
 if (level >= TRIM_MEMORY_RUNNING_LOW)
 Framework.nativeMemoryWarning();
 }
+
+ public void onCancelledFromBackground(){


What do you think about routing STOP_NAVIGATION intent via MwmActiviy instead of sending it directly to NavigationService? The intent will appear in MwmActiviy.onNewIntent(), where it will be possible to stop the NavigationService and restore the UI of MwmActivity. It should work regardless of the current foreground/background state of MwmActivity. This approach eliminates the need for IS_CANCELLED_FROM_BACKGROUND flag stored in Preferences.

Thank you for the guidance, idea seems perfect will work upon it.

kavikhalique · 2024-04-29T22:18:56Z

Could you please evaluate the idea of routing STOP_NAVIGATION intent via MwmActivity to eliminate the need of using IS_CANCELLED_FROM_BACKGROUND flag in Preferences (see a comment inline)? I think it would make the code even much simpler.

I dont know why this idea didn't strike in my mind. Your idea is much better and clean will modify the code accordingly and will update you ASAP.

The only doubt i have is, if we will send intent to activity class it will open up the activity in foreground (means it will open the app)

I will check this out once and then will update you

kavikhalique · 2024-04-30T17:45:31Z

I have tried that but the issue is with UX.

If we will route STOP_NAVIGATION through mwmActivity it opens the app in foreground.

But if the navigation is cancelled from background it should not bring the app in foreground. It should just close the notification.
@rtsisyk

rtsisyk

Thanks for reworking this PR. Simplicity the key to brilliance.

I am ready to merge this PR. Could you please fix two minor issues before merging?

Remove unused constants and imports from NavigationService,java
Please squash all commits into one:

git rebase -i HEAD~6 # six commits
change "pick" to "squash" to everything except the first commit
reword the first commit
push it back to the repo (git push origin exit-button-navigation:exit-button-navigation -f)

rtsisyk · 2024-05-25T15:02:29Z

android/app/src/main/java/app/organicmaps/routing/NavigationService.java

+ private static final String STOP_NAVIGATION = "STOP_NAVIGATION";
+ private static final String NAVIGATION = "NAVIGATION";
+ private static final String IS_APP_IN_BACKGROUND = "isAppInBackground";
+ private static final String IS_CANCELLED_FROM_BACKGROUND = "isCancelledFromBackground";


Could you please remove unused constants?

rtsisyk · 2024-05-25T17:30:13Z

android/app/src/main/java/app/organicmaps/routing/NavigationService.java

+ {
+ RoutingController.get().cancel();
+ stopSelf();
+ }


Sorry for the late comment, but it looks like that we forgot return START_NOT_STICKY; // The service will be stopped by stopSelf(). here. Please 6 lines below.

rtsisyk · 2024-05-25T17:40:39Z

android/app/src/main/java/app/organicmaps/routing/NavigationService.java

@@ -184,6 +191,14 @@ public void onLowMemory()
 @Override
 public int onStartCommand(@NonNull Intent intent, int flags, int startId)
 {
+ final String action = intent.getAction();
+ if (action != null && action.equals(STOP_NAVIGATION))
+ {


nit: should be on the previous line..

rtsisyk · 2024-05-25T17:41:03Z

Thanks for your patience!!

Signed-off-by: kavikhalique <[email protected]>

Signed-off-by: kavi khalique <[email protected]>

Jean-BaptisteC requested review from biodranik and rtsisyk April 19, 2024 06:12

biodranik approved these changes Apr 19, 2024

View reviewed changes

android/app/src/main/java/app/organicmaps/routing/NavigationService.java Show resolved Hide resolved

android/app/src/main/java/app/organicmaps/routing/NavigationService.java Outdated Show resolved Hide resolved

biodranik reviewed Apr 20, 2024

View reviewed changes

rtsisyk reviewed Apr 26, 2024

View reviewed changes

rtsisyk self-assigned this Apr 27, 2024

kavikhalique requested a review from rtsisyk May 24, 2024 21:50

rtsisyk reviewed May 25, 2024

View reviewed changes

kavikhalique force-pushed the exit-button-navigation branch 3 times, most recently from 0db2c53 to 71271da Compare May 25, 2024 17:21

rtsisyk reviewed May 25, 2024

View reviewed changes

kavikhalique force-pushed the exit-button-navigation branch from 71271da to a933eb2 Compare May 25, 2024 17:39

rtsisyk reviewed May 25, 2024

View reviewed changes

rtsisyk approved these changes May 25, 2024

View reviewed changes

[android] Implements exit button in navigation notification

97ff278

Signed-off-by: kavikhalique <[email protected]>

kavikhalique force-pushed the exit-button-navigation branch from a933eb2 to 97ff278 Compare May 25, 2024 18:13

Merge branch 'master' into exit-button-navigation

f30f936

Signed-off-by: kavi khalique <[email protected]>

rtsisyk merged commit b3cccaf into organicmaps:master May 25, 2024
6 checks passed

j13m126 mentioned this pull request Jun 1, 2024

Problematic Exit navigation string #8357

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[android] Implements exit button in navigation notification #7953

[android] Implements exit button in navigation notification #7953

kavikhalique commented Apr 18, 2024

biodranik left a comment

RedAuburn commented Apr 19, 2024

kavikhalique commented Apr 19, 2024

Jean-BaptisteC commented Apr 19, 2024

kavikhalique commented Apr 19, 2024

biodranik commented Apr 19, 2024

kavikhalique commented Apr 19, 2024

kavikhalique commented Apr 19, 2024 •

edited

kavikhalique commented Apr 20, 2024

biodranik left a comment

kavikhalique commented Apr 20, 2024

kavikhalique commented Apr 23, 2024

rtsisyk commented Apr 24, 2024

rtsisyk left a comment

rtsisyk Apr 26, 2024

kavikhalique Apr 29, 2024

kavikhalique commented Apr 29, 2024 •

edited

kavikhalique commented Apr 30, 2024

rtsisyk left a comment •

edited

rtsisyk May 25, 2024

rtsisyk May 25, 2024

kavikhalique May 25, 2024

rtsisyk May 25, 2024

rtsisyk commented May 25, 2024

[android] Implements exit button in navigation notification #7953

[android] Implements exit button in navigation notification #7953

Conversation

kavikhalique commented Apr 18, 2024

biodranik left a comment

Choose a reason for hiding this comment

RedAuburn commented Apr 19, 2024

kavikhalique commented Apr 19, 2024

Jean-BaptisteC commented Apr 19, 2024

kavikhalique commented Apr 19, 2024

biodranik commented Apr 19, 2024

kavikhalique commented Apr 19, 2024

kavikhalique commented Apr 19, 2024 • edited

kavikhalique commented Apr 20, 2024

biodranik left a comment

Choose a reason for hiding this comment

kavikhalique commented Apr 20, 2024

kavikhalique commented Apr 23, 2024

rtsisyk commented Apr 24, 2024

rtsisyk left a comment

Choose a reason for hiding this comment

rtsisyk Apr 26, 2024

Choose a reason for hiding this comment

kavikhalique Apr 29, 2024

Choose a reason for hiding this comment

kavikhalique commented Apr 29, 2024 • edited

kavikhalique commented Apr 30, 2024

rtsisyk left a comment • edited

Choose a reason for hiding this comment

rtsisyk May 25, 2024

Choose a reason for hiding this comment

rtsisyk May 25, 2024

Choose a reason for hiding this comment

kavikhalique May 25, 2024

Choose a reason for hiding this comment

rtsisyk May 25, 2024

Choose a reason for hiding this comment

rtsisyk commented May 25, 2024

kavikhalique commented Apr 19, 2024 •

edited

kavikhalique commented Apr 29, 2024 •

edited

rtsisyk left a comment •

edited