feat(cost-explorer): AnomalyMonitor and AnomalySubscription type #39
Conversation
Codecov Report
@@ Coverage Diff @@
## master #39 +/- ##
=======================================
Coverage 82.71% 82.71%
=======================================
Files 12 12
Lines 972 972
Branches 141 141
=======================================
Hits 804 804
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
OlafConijn
changed the title
OlafConijn
changed the title
| await service.deleteAnomalyMonitor({ MonitorArn: model.arn }).promise(); | ||
|
|
||
| return Promise.resolve(null); | ||
| } |
| model.arn = response.MonitorArn; | ||
| return Promise.resolve(model); | ||
| } | ||
|
|
There was a problem hiding this comment.
Why there is no update handler?
| @@ -0,0 +1,18 @@ | |||
| # Distribution / packaging | |||
| @@ -0,0 +1,18 @@ | |||
| # Distribution / packaging | |||
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", | ||
| "class-transformer": "^0.3.1", | ||
| "uuid": "^7.0.3", | ||
| "aws-sdk": "2.775.0" |
There was a problem hiding this comment.
aws sdk should be moved to optional dependencies, because the minimum lambda version now is 2.771.0
| "devDependencies": { | ||
| "@types/node": "^12.0.0", | ||
| "@types/uuid": "^7.0.3", | ||
| "typescript": "^3.8.3" |
There was a problem hiding this comment.
this should be "typescript": "^4.1.2" to make sure we use the hoisted version across the whole repository
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", | ||
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", |
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", |
| "devDependencies": { | ||
| "@types/node": "^12.0.0", | ||
| "@types/uuid": "^7.0.3", | ||
| "typescript": "^3.8.3" |
There was a problem hiding this comment.
this should be "typescript": "^4.1.2"
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", | ||
| "class-transformer": "^0.3.1", | ||
| "uuid": "^7.0.3", | ||
| "aws-sdk": "2.775.0" |
| "test": "echo \"Error: no test specified\" && exit 1" | ||
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", |
| }, | ||
| "dependencies": { | ||
| "aws-resource-providers-common": "^0.2.0", | ||
| "cfn-rpdk": "npm:@org-formation/cfn-rpdk@^0.4.0", |
|
@OlafConijn i think AWS has a CFN resource for this now? https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-ce-anomalymonitor.html |
OlafConijn
force-pushed
the
master
branch
2 times, most recently
from
9d87809
to
cec8fd2
Compare
Issue #, if available: #36
Description of changes: