Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add flag to skip deleting obsolete referrers index #957

Merged
merged 48 commits into from
Jul 3, 2023
Merged
Changes from 1 commit
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
8b22600
feat!: add flag for referrers GC
qweeah May 29, 2023
7b7e5a4
update go mod
qweeah May 29, 2023
e27d723
fix e2e
qweeah May 29, 2023
57b4e75
add e2e
qweeah May 29, 2023
adfcca1
update deps
qweeah May 29, 2023
cacd6bb
update dep
qweeah May 30, 2023
f0ecebf
update
qweeah May 30, 2023
ffbd8bc
update version
qweeah May 30, 2023
d5f1937
mod tidy
qweeah May 30, 2023
abae524
fix e2e
qweeah May 30, 2023
06d382d
rename flag
qweeah Jun 1, 2023
86f3b1d
fix: default to true
qweeah Jun 2, 2023
19c4516
fix e2e
qweeah Jun 2, 2023
623dc99
change default value to false
qweeah Jun 6, 2023
aa73bc9
fix e2e
qweeah Jun 6, 2023
aa91493
fix e2e
qweeah Jun 6, 2023
06af37b
refactor: simplify e2e scripts and github action
qweeah Jun 6, 2023
f78e02d
fix makefile
qweeah Jun 6, 2023
3b2f883
fix e2e
qweeah Jun 6, 2023
5d1b6f2
remove global coverage dump path
qweeah Jun 6, 2023
71a1551
feat!: add flag for referrers GC
qweeah May 29, 2023
8c34fb3
update go mod
qweeah May 29, 2023
f0ddea5
fix e2e
qweeah May 29, 2023
d5d1b75
add e2e
qweeah May 29, 2023
c7fc74b
update deps
qweeah May 29, 2023
84a9542
update dep
qweeah May 30, 2023
0d3705d
update
qweeah May 30, 2023
ce74b34
update version
qweeah May 30, 2023
43f8b3e
mod tidy
qweeah May 30, 2023
9664843
fix e2e
qweeah May 30, 2023
a397824
rename flag
qweeah Jun 1, 2023
7984217
fix: default to true
qweeah Jun 2, 2023
cd95fa1
fix e2e
qweeah Jun 2, 2023
da91691
change default value to false
qweeah Jun 6, 2023
b302cdb
fix e2e
qweeah Jun 6, 2023
e698088
fix e2e
qweeah Jun 6, 2023
785e8b9
test: add e2e for referrers GC
qweeah Jun 6, 2023
be69555
Merge branch 'gc-referrers' of github.com:qweeah/oras into gc-referrers
qweeah Jun 6, 2023
1084fa6
add error hint
qweeah Jun 8, 2023
6ba07e5
Merge branch 'main' into gc-referrers
Jun 8, 2023
f033ead
Merge branch 'main' into gc-referrers
qweeah Jun 9, 2023
4e9b9fa
Merge branch 'gc-referrers' of github.com:qweeah/oras into gc-referrers
qweeah Jun 9, 2023
bec6661
Merge branch 'main' into gc-referrers
qweeah Jun 28, 2023
a69435d
Merge branch 'main' into gc-referrers
qweeah Jun 28, 2023
fdc59b8
Merge remote-tracking branch 'origin-upstream/main' into gc-referrers
qweeah Jun 29, 2023
6b92395
bug fix
qweeah Jun 29, 2023
757f2ae
update comment
qweeah Jul 3, 2023
474c798
Merge branch 'main' into gc-referrers
qweeah Jul 3, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix e2e
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah committed Jun 6, 2023
commit e27d723c35cfd5b699126f241f9b9451367fc85e
6 changes: 3 additions & 3 deletions cmd/oras/internal/option/referrers.go
Original file line number Diff line number Diff line change
@@ -34,10 +34,10 @@ func (opts *Referrers) ApplyFlags(fs *pflag.FlagSet) {

// SetReferrersGC sets the referrers GC option for the passed-in target.
func (opts *Referrers) SetReferrersGC(target any) error {
repo, ok := target.(*remote.Repository)
if !ok {
if repo, ok := target.(*remote.Repository); ok {
repo.ReferrersGC = opts.GC
} else if opts.GC {
return errors.New("referrers GC can only be enforced to registry targets")
}
repo.ReferrersGC = opts.GC
return nil
}
2 changes: 2 additions & 0 deletions test/e2e/go.mod
Original file line number Diff line number Diff line change
@@ -2,6 +2,8 @@ module oras.land/oras/test/e2e

go 1.20

replace oras.land/oras-go/v2 => github.com/qweeah/oras-go/v2 v2.0.0-20230526033205-9b4915420e0b

require (
github.com/onsi/ginkgo/v2 v2.9.7
github.com/onsi/gomega v1.27.7
4 changes: 2 additions & 2 deletions test/e2e/go.sum
Original file line number Diff line number Diff line change
@@ -24,6 +24,8 @@ github.com/opencontainers/image-spec v1.1.0-rc.3 h1:GT9Xon8YrLxz6N7sErbN81V8J4lO
github.com/opencontainers/image-spec v1.1.0-rc.3/go.mod h1:X4pATf0uXsnn3g5aiGIsVnJBR4mxhKzfwmvK/B2NTm8=
github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM=
github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
github.com/qweeah/oras-go/v2 v2.0.0-20230526033205-9b4915420e0b h1:MoOGc1X5qRL+n4AtzaI9TgzLcsDbWSgU34/gVB1shQs=
github.com/qweeah/oras-go/v2 v2.0.0-20230526033205-9b4915420e0b/go.mod h1:pXjn0+KfarspMHHNR3A56j3tgvr+mxArHuI8qVn59v8=
github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
github.com/stretchr/testify v1.6.1/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg=
github.com/stretchr/testify v1.7.0 h1:nwc3DEeHmmLAfoZucVR881uASk0Mfjw8xYJ99tb5CcY=
@@ -47,5 +49,3 @@ gopkg.in/yaml.v2 v2.4.0/go.mod h1:RDklbk79AGWmwhnvt/jBztapEOGDOx6ZbXqjP6csGnQ=
gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA=
gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM=
oras.land/oras-go/v2 v2.2.0 h1:E1fqITD56Eg5neZbxBtAdZVgDHD6wBabJo6xESTcQyo=
oras.land/oras-go/v2 v2.2.0/go.mod h1:pXjn0+KfarspMHHNR3A56j3tgvr+mxArHuI8qVn59v8=